From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBqpb-0004Zi-61 for qemu-devel@nongnu.org; Sun, 05 Jul 2015 16:48:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBqpX-0006xK-U3 for qemu-devel@nongnu.org; Sun, 05 Jul 2015 16:48:07 -0400 Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:36383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBqpX-0006x4-MV for qemu-devel@nongnu.org; Sun, 05 Jul 2015 16:48:03 -0400 Received: by lagc2 with SMTP id c2so133062485lag.3 for ; Sun, 05 Jul 2015 13:48:02 -0700 (PDT) Message-ID: <559997FB.4030301@gmail.com> Date: Sun, 05 Jul 2015 23:47:55 +0300 From: Dmitry Osipenko MIME-Version: 1.0 References: <1436128000-16262-1-git-send-email-crosthwaite.peter@gmail.com> In-Reply-To: <1436128000-16262-1-git-send-email-crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Crosthwaite 05.07.2015 23:26, Peter Crosthwaite пишет: > Hi Dmitry, > > Based on my comment earlier, this is what I came up with RE consolidation of > those arm_mptimer code paths that were giving you problems. I have not done the > interrupt mask fix, as that one from your series is reasonably independent. > > Regards, > Peter > > Peter Crosthwaite (2): > timer: arm_mp: Factor out timer value calculation > timer: arm_mp: consolidate control and counter write logic > > hw/timer/arm_mptimer.c | 73 +++++++++++++++++++++++++++++--------------------- > 1 file changed, 42 insertions(+), 31 deletions(-) > Hi Peter, thanks a lot! Generally, I don't have any trouble with currently missed functionality, just noticed it while was hacking my NVIDIA Tegra2 emulation pet-project and decided to contribute =). It looks like you are trying to duplicate what generic ptimer is already doing, isn't it? -- Dmitry