From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZBrU7-0000DT-BW
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 17:30:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZBrU3-000129-TJ
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 17:29:59 -0400
Received: from mail-la0-x22a.google.com ([2a00:1450:4010:c03::22a]:36187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZBrU3-00010w-K2
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 17:29:55 -0400
Received: by lagc2 with SMTP id c2so133586095lag.3
	for <qemu-devel@nongnu.org>; Sun, 05 Jul 2015 14:29:54 -0700 (PDT)
Message-ID: <5599A1CB.4080203@gmail.com>
Date: Mon, 06 Jul 2015 00:29:47 +0300
From: Dmitry Osipenko <digetx@gmail.com>
MIME-Version: 1.0
References: <1435877531-24983-1-git-send-email-digetx@gmail.com>	<1436110742-6190-1-git-send-email-digetx@gmail.com>	<1436110742-6190-2-git-send-email-digetx@gmail.com>
	<CAEgOgz7YRvoDDmuLfMq0Qw-HONbJeDVzvk4UKR=hr+bxyZGi8w@mail.gmail.com>
In-Reply-To: <CAEgOgz7YRvoDDmuLfMq0Qw-HONbJeDVzvk4UKR=hr+bxyZGi8w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/2] arm_mptimer: Fix timer shutdown and
 mode change
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

06.07.2015 00:19, Peter Crosthwaite пишет:
> On Sun, Jul 5, 2015 at 8:39 AM, Dmitry Osipenko <digetx@gmail.com> wrote:
>> Timer, running in periodic mode, can't be stopped or coming one-shot
>> tick won't be canceled because timer control code just doesn't handle
>> timer disabling. Fix it by deleting the timer if enable bit isn't set.
>>
> You don't need to itemize one-shot and periodic separately, disabling
> the running timer just doesn't work universally.
>

Fair enough.


>> Timer won't start periodic ticking if ONE-SHOT -> PERIODIC mode change
>> happened after one-shot tick was completed. Fix it by starting ticking
>> only if the timer isn't ticking right now.
>>
>
> Needs some grammar work. Try:
>
> The running timer can't be stopped because timer control code just
> doesn't handle disabling the timer. Fix it by deleting the timer if
> the enable bit is cleared.
>
> The timer won't start periodic ticking if a ONE-SHOT -> PERIODIC mode
> change happens after a one-shot tick was completed. Fix it by
> re-starting ticking if the timer isn't ticking right now.
>
> Otherwise:
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> Regards,
> Peter
>

Sounds good, I'll pick it. Thanks.

-- 
Dmitry