From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: peter.maydell@linaro.org, hpoussin@reactos.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: implement cfg capability
Date: Mon, 6 Jul 2015 10:46:31 +0200 [thread overview]
Message-ID: <559A4067.3060109@redhat.com> (raw)
In-Reply-To: <20150706105048-mutt-send-email-mst@redhat.com>
On 06/07/2015 10:33, Michael S. Tsirkin wrote:
> Also, by luck, some values work the same whatever the endian-ness.
> E.g. dma_memory_set fills the buffer with a given pattern, so
> nothing changes if you byte-swap it.
>
> Here's an example that's wrong: dp8393x. Typically it's accessing
> memory for DMA, so there's no byteswap. Works fine.
>
> But should device attempt to access another device memory,
> it would break because MIPS target is BE.
>
> Cc Hervé for confirmation.
>
> I conclude that virtio is not so special in needing a variant
> of address_space_rw that assumes host endian format for the data.
Why host endian and not device (in this case little) endian?
Paolo
next prev parent reply other threads:[~2015-07-06 8:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 13:00 [Qemu-devel] [PATCH] virtio-pci: implement cfg capability Michael S. Tsirkin
2015-07-02 18:48 ` Paolo Bonzini
2015-07-02 19:00 ` Michael S. Tsirkin
2015-07-02 19:02 ` Paolo Bonzini
2015-07-04 21:19 ` Michael S. Tsirkin
2015-07-06 7:46 ` Paolo Bonzini
2015-07-06 8:33 ` Michael S. Tsirkin
2015-07-06 8:46 ` Paolo Bonzini [this message]
2015-07-06 9:06 ` Michael S. Tsirkin
2015-07-06 9:11 ` Peter Maydell
2015-07-06 10:03 ` Michael S. Tsirkin
2015-07-06 10:04 ` Peter Maydell
2015-07-06 10:31 ` Michael S. Tsirkin
2015-07-06 11:50 ` Peter Maydell
2015-07-06 12:04 ` Paolo Bonzini
2015-07-06 12:15 ` Michael S. Tsirkin
2015-07-06 12:12 ` Michael S. Tsirkin
2015-07-06 12:23 ` Paolo Bonzini
2015-07-03 9:34 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A4067.3060109@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpoussin@reactos.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).