From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Crosthwaite <crosthwaitepeter@gmail.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic
Date: Mon, 6 Jul 2015 11:00:36 +0200 [thread overview]
Message-ID: <559A43B4.6050901@redhat.com> (raw)
In-Reply-To: <CAEgOgz60KUMS=RrGOh9L=nbnDW5JT-s1HQjYLKdePvhsdqHemw@mail.gmail.com>
On 06/07/2015 10:58, Peter Crosthwaite wrote:
>> > Which compiler version started implementing anonymous structs?
>> >
> ISO C11 standardises it apparently. But various parts of the tree use
> them now. target-arm/cpu.h, target-i386/kvm.c,
> linux-user/syscall_defs.h and linux-headers/linux/kvm.h have liberal
> use to name a few. I have seen it used in devs from time to time for
> unionifying individual registers with an array form for SW access.
>
> This led me to consider it open season on anonymous structs and unions.
Ok, I wasn't sure about anonymous structs. We definitely use anonymous
unions a lot.
>> > Or can we just add
>> >
>> > __attribute__((__aligned__(1 << CPU_TLB_ENTRY_BITS)))
>> >
> Is that more or less standard than anonymous structs?
Not standard (though there is something in C11 too) but decades old as a
GCC extension.
Paolo
next prev parent reply other threads:[~2015-07-06 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 21:08 [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic Peter Crosthwaite
2015-07-06 8:43 ` Paolo Bonzini
2015-07-06 8:58 ` Peter Crosthwaite
2015-07-06 9:00 ` Paolo Bonzini [this message]
2015-07-06 11:42 ` Richard Henderson
2015-07-06 11:52 ` Paolo Bonzini
2015-07-06 21:46 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A43B4.6050901@redhat.com \
--to=pbonzini@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).