From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1ZC4vQ-000601-AA
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 07:51:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1ZC4vN-00078j-3x
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 07:51:04 -0400
Message-ID: <559A6BA0.3030109@suse.de>
Date: Mon, 06 Jul 2015 13:50:56 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1435869974-22848-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<20150703071841.GC16378@voom.redhat.com> <559A421B.3030707@suse.de>
	<20150706110931.GA32578@voom.redhat.com>
In-Reply-To: <20150706110931.GA32578@voom.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-ppc: fix hugepage support when
	using memory-backend-file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-stable@nongnu.org, qemu-ppc@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 07/06/15 13:09, David Gibson wrote:
> On Mon, Jul 06, 2015 at 10:53:47AM +0200, Alexander Graf wrote:
>> On 07/03/15 09:18, David Gibson wrote:
>>> On Thu, Jul 02, 2015 at 03:46:14PM -0500, Michael Roth wrote:
>>>> Current PPC code relies on -mem-path being used in order for
>>>> hugepage support to be detected. With the introduction of
>>>> MemoryBackendFile we can now handle this via:
>>>>    -object memory-file-backend,mem-path=...,id=hugemem0 \
>>>>    -numa node,id=mem0,memdev=hugemem0
>>>>
>>>> Management tools like libvirt treat the 2 approaches as
>>>> interchangeable in some cases, which can lead to user-visible
>>>> regressions even for previously supported guest configurations.
>>>>
>>>> Fix these by also iterating through any configured memory
>>>> backends that may be backed by hugepages.
>>>>
>>>> Since the old code assumed hugepages always backed the entirety
>>>> of guest memory, play it safe an pick the minimum across the
>>>> max pages sizes for all backends, even ones that aren't backed
>>>> by hugepages.
>>>>
>>>> Cc: qemu-stable@nongnu.org
>>>> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
>>> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>>>
>> Thanks, applied to ppc-next.
> Hrm.. I see that you've pushed out ppc-next with this patch, but looks
> like it hasn't been rebased on latest master.

Yup. Done now.


Alex