From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42258)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZC51K-0003fM-PY
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 07:57:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZC51G-0001Is-42
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 07:57:10 -0400
Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:36575)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZC51F-0001In-VI
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 07:57:06 -0400
Received: by qgeg89 with SMTP id g89so67533452qge.3
	for <qemu-devel@nongnu.org>; Mon, 06 Jul 2015 04:57:05 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <20150706082535.11980.88013.stgit@PASHA-ISP>
	<20150706082600.11980.88549.stgit@PASHA-ISP>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <559A6D0D.1070308@twiddle.net>
Date: Mon, 6 Jul 2015 12:57:01 +0100
MIME-Version: 1.0
In-Reply-To: <20150706082600.11980.88549.stgit@PASHA-ISP>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 04/11] target-i386: introduce new
 raise_exception functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com, agraf@suse.de, aurelien@aurel32.net

On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
>   #if 0
> -#define raise_exception_err(env, a, b)                                  \
> +#define raise_exception_err(env, a, b, c)                               \
>       do {                                                                \
>           qemu_log("raise_exception line=%d\n", __LINE__);                \
> -        (raise_exception_err)(env, a, b);                               \
> +        (raise_exception_err)(env, a, b, c);                            \
>       } while (0)
>   #endif
>

This change wouldn't compile.  That said, I'm ok simply deleting the whole if 0 
block.  I think keeping it around is silly.


r~