From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC5HQ-0006Io-8q for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:13:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZC5HL-0001bD-8y for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:13:48 -0400 Received: from mail-qg0-x22b.google.com ([2607:f8b0:400d:c04::22b]:34677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC5HL-0001b1-4K for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:13:43 -0400 Received: by qgii30 with SMTP id i30so67763324qgi.1 for ; Mon, 06 Jul 2015 05:13:42 -0700 (PDT) Sender: Richard Henderson References: <20150706082535.11980.88013.stgit@PASHA-ISP> <20150706082622.11980.74680.stgit@PASHA-ISP> From: Richard Henderson Message-ID: <559A70EA.2040109@twiddle.net> Date: Mon, 6 Jul 2015 13:13:30 +0100 MIME-Version: 1.0 In-Reply-To: <20150706082622.11980.74680.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, leon.alrae@imgtec.com, agraf@suse.de, aurelien@aurel32.net On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote: > This patch fixes exception handling for seg_helper functions. > > Signed-off-by: Pavel Dovgalyuk No, you don't want to discriminately change every call. That was my original point about not needing to change seg_helper.c or smm_helper.c. Further, any such changes would go along with the changes in translate.c to remove the state saving there. I would only change those that are "normal" memory operations, like fp loads etc. The segmentation changes are rare. The task state helpers require state saving anyway, so requiring a TCG search is a pessimization. r~