From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v2 00/13] KVM patches (SMM implementation) for 2015-07-06
Date: Mon, 6 Jul 2015 18:40:51 +0200 [thread overview]
Message-ID: <559AAF93.4020302@redhat.com> (raw)
In-Reply-To: <CAFEAcA-OzN8FuB7hicM8VfA8o0bqt479gFO8-PCmbb4Ke5WLaw@mail.gmail.com>
On 06/07/2015 18:31, Peter Maydell wrote:
> I'm afraid this doesn't build on OSX or on ARM Linux
> (or likely any build host where x86 isn't a CONFIG_KVM build):
>
> CC i386-softmmu/hw/i386/pc_piix.o
> /Users/pm215/src/qemu/hw/i386/pc.c:1782:56: error: use of undeclared identifier
> 'KVM_CAP_X86_SMM'
> smm_available = kvm_check_extension(kvm_state, KVM_CAP_X86_SMM);
> ^
> 1 error generated.
>
> Putting #ifdef CONFIG_KVM around the offending line fixes this;
> there may be a cleaner approach.
Indeed the same file already does something cleaner for
kvm_allows_irq0_override().
Paolo
prev parent reply other threads:[~2015-07-06 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 16:18 [Qemu-devel] [PULL v2 00/13] KVM patches (SMM implementation) for 2015-07-06 Paolo Bonzini
2015-07-06 16:18 ` [Qemu-devel] [PULL 03/13] target-i386: add support for SMBASE MSR and SMIs Paolo Bonzini
2015-07-06 16:31 ` [Qemu-devel] [PULL v2 00/13] KVM patches (SMM implementation) for 2015-07-06 Peter Maydell
2015-07-06 16:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559AAF93.4020302@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).