From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC9Rz-0005YF-3g for qemu-devel@nongnu.org; Mon, 06 Jul 2015 12:40:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZC9Rv-0002mi-Rq for qemu-devel@nongnu.org; Mon, 06 Jul 2015 12:40:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC9Rv-0002mb-MP for qemu-devel@nongnu.org; Mon, 06 Jul 2015 12:40:55 -0400 References: <1436199533-41111-1-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <559AAF93.4020302@redhat.com> Date: Mon, 6 Jul 2015 18:40:51 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v2 00/13] KVM patches (SMM implementation) for 2015-07-06 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 06/07/2015 18:31, Peter Maydell wrote: > I'm afraid this doesn't build on OSX or on ARM Linux > (or likely any build host where x86 isn't a CONFIG_KVM build): > > CC i386-softmmu/hw/i386/pc_piix.o > /Users/pm215/src/qemu/hw/i386/pc.c:1782:56: error: use of undeclared identifier > 'KVM_CAP_X86_SMM' > smm_available = kvm_check_extension(kvm_state, KVM_CAP_X86_SMM); > ^ > 1 error generated. > > Putting #ifdef CONFIG_KVM around the offending line fixes this; > there may be a cleaner approach. Indeed the same file already does something cleaner for kvm_allows_irq0_override(). Paolo