From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1ZC9Wl-0000Py-2G
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 12:45:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1ZC9Wj-00007v-Eh
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 12:45:54 -0400
Message-ID: <559AB0BD.3070602@redhat.com>
Date: Mon, 06 Jul 2015 18:45:49 +0200
From: Laurent Vivier <lvivier@redhat.com>
MIME-Version: 1.0
References: <1436148670-6592-1-git-send-email-aik@ozlabs.ru>
	<1436148670-6592-7-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1436148670-6592-7-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH qemu v10 06/14] spapr_iommu: Remove
 vfio_accel flag from sPAPRTCETable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, qemu-ppc@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, Gavin Shan <gwshan@linux.vnet.ibm.com>



On 06/07/2015 04:11, Alexey Kardashevskiy wrote:
> sPAPRTCETable has a vfio_accel flag which is passed to
> kvmppc_create_spapr_tce() and controls whether to create a guest view
> table in KVM as this depends on the host kernel ability to accelerate
> H_PUT_TCE for VFIO devices. We would set this flag at the moment
> when sPAPRTCETable is created in spapr_tce_new_table() and
> use when the table is allocated in spapr_tce_table_realize().
> 
> Now we explicitly enable/disable DMA windows via spapr_tce_table_enable()
> and spapr_tce_table_disable() and can pass this flag directly without
> caching it in sPAPRTCETable.
> 
> This removes the flag. This should cause no behavioural change.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> Changes:
> v8:
> * new to patchset, this is cleanup
> ---
>  hw/ppc/spapr_iommu.c   | 8 +++-----
>  include/hw/ppc/spapr.h | 1 -
>  2 files changed, 3 insertions(+), 6 deletions(-)


Reviewed-by: Laurent Vivier <lvivier@redhat.com>