From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCEPd-0004Q3-Bz for qemu-devel@nongnu.org; Mon, 06 Jul 2015 17:58:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCEPa-0003FQ-5Q for qemu-devel@nongnu.org; Mon, 06 Jul 2015 17:58:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCEPZ-0003FG-UJ for qemu-devel@nongnu.org; Mon, 06 Jul 2015 17:58:50 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E8E8C363614 for ; Mon, 6 Jul 2015 21:58:48 +0000 (UTC) Message-ID: <559AFA11.8080703@redhat.com> Date: Mon, 06 Jul 2015 23:58:41 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1435239307-13369-1-git-send-email-lersek@redhat.com> <1435239307-13369-3-git-send-email-lersek@redhat.com> <87ioaa24uc.fsf@blackfin.pond.sub.org> <558D44C6.4070807@redhat.com> <558D9EDC.3020905@redhat.com> <20150626190914.GA26073@thinpad.lan.raisama.net> <87twtqsvt5.fsf@blackfin.pond.sub.org> <20150629115543-mutt-send-email-mst@redhat.com> In-Reply-To: <20150629115543-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Jan Tomko , Eduardo Habkost , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , John Snow On 06/29/15 11:56, Michael S. Tsirkin wrote: > On Mon, Jun 29, 2015 at 11:33:42AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> On Fri, Jun 26, 2015 at 02:50:04PM -0400, John Snow wrote: >>>> On 06/26/2015 08:25 AM, Laszlo Ersek wrote: >>>>> On 06/26/15 11:31, Markus Armbruster wrote: >>>>>> Laszlo Ersek writes: >>>>>> >>>>>>> With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: >>>>>>> >>>>>>> -device isa-fdc,driveA=drive-fdc0-0-0 \ >>>>>>> -drive file=...,if=none,id=drive-fdc0-0-0,format=raw >>>>>>> >>>>>>> then the board-default FDC will be skipped, and only the explicitly >>>>>>> requested FDC will exist. qtree-wise, this is correct; however such an FDC >>>>>>> is currently not registered in the CMOS, because that code is only reached >>>>>>> for the board-default FDC. >>>>>>> >>>>>>> The pc_cmos_init_late() one-shot reset handler -- one-shot because the >>>>>>> CMOS is not reprogrammed during warm reset -- should search for any ISA >>>>>>> FDC devices, created implicitly (by board code) or explicitly, and set the >>>>>>> CMOS accordingly to the ISA FDC(s) with iobase=0x3f0: >>>>>>> >>>>>>> - if there is no such FDC, report both drives absent, >>>>>>> - if there is exactly one such FDC, report its drives in the CMOS, >>>>>>> - if there are more than one such FDCs, then pick one (it is not specified >>>>>>> which one), and print a warning about the ambiguity. >>>>>>> >>>>>>> Cc: Jan Tomko >>>>>>> Cc: John Snow >>>>>>> Cc: Markus Armbruster >>>>>>> Cc: Paolo Bonzini >>>>>>> Reported-by: Jan Tomko >>>>>>> Suggested-by: Markus Armbruster >>>>>>> Signed-off-by: Laszlo Ersek >>>>>>> Reviewed-by: John Snow >>>>>> >>>>>> Reviewed-by: Markus Armbruster >>>>> >>>>> Thank you. Can you or John please send a PULL req for this? (Or include >>>>> it in an upcoming PULL of yours.) >>>>> >>>>> I've been Cc'ing Paolo because the get-maintainer script reported him at >>>>> the top for the patch set, but I believe he might not have time for this >>>>> now. >>>>> >>>>> Thanks! >>>>> Laszlo >>>>> >>>> >>>> This is technically out-of-tree for me, because it's touching init >>>> instead of my device. >>>> >>>> Best guess is Eduardo Habkost, whom I have CC'd. >>> >>> Michael is the PC maintainer. >> >> Michael, we really needs this series in 2.4, because without it floppy >> is broken for Q35. > > Will review, thanks for the reminder. Ping. :) This should go into 2.4, preferably. (Tomorrow ^W in two minutes in my timezone is the rc0 / hard freeze date (according to ), but the series is a bugfix.) Thanks Laszlo