From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Auger <eric.auger@linaro.org>,
eric.auger@st.com, qemu-devel@nongnu.org,
peter.maydell@linaro.org, peter.crosthwaite@xilinx.com
Cc: christoffer.dall@linaro.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done
Date: Tue, 7 Jul 2015 11:02:24 +0200 [thread overview]
Message-ID: <559B95A0.6090208@redhat.com> (raw)
In-Reply-To: <559B9511.5060701@linaro.org>
On 07/07/2015 11:00, Eric Auger wrote:
> Hi Paolo, Peter,
> On 06/22/2015 11:58 AM, Eric Auger wrote:
>> On 06/22/2015 11:53 AM, Paolo Bonzini wrote:
>>>
>>>
>>> On 22/06/2015 11:49, Eric Auger wrote:
>>>>>> It seems safe because rom_load_all really doesn't load anything, it only
>>>>>> does an overlap check. Is this right?
>>>> it does the check + isrom field setting
>>>>>>
>>>>>> Is the bug that some overlapping ROMs are not detected? The commit
>>>>>> message is not clear.
>>>> The regression is that the both overlap check and isrom setting are not
>>>> done since ROM are inserted in the roms list afterwards, at machine init
>>>> done time. The bug was not really observed yet I think.
>>>
>>> isrom is just an optimization though, right? What is it useful for?
>> My understanding is it serves 2 purposes:
>>
>> - report info in the monitor (hmp_info_roms)
>> - decide whether the rom->data can be freed on ROM reset notifier
>> (rom_reset).
>>
>> Hope I didn't miss anything else.
>>
>> Eric
>
> What do we decide then about this regression on arm. Do we fix it in 2.4
> or later?
Yes, it should be fixed in 2.4.
Paolo
next prev parent reply other threads:[~2015-07-07 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 16:07 [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done Eric Auger
2015-06-22 9:26 ` Eric Auger
2015-06-22 9:43 ` Paolo Bonzini
2015-06-22 9:49 ` Eric Auger
2015-06-22 9:53 ` Paolo Bonzini
2015-06-22 9:58 ` Eric Auger
2015-07-07 9:00 ` Eric Auger
2015-07-07 9:02 ` Paolo Bonzini [this message]
2015-07-07 9:07 ` Eric Auger
2015-07-07 9:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559B95A0.6090208@redhat.com \
--to=pbonzini@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=patches@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).