From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCOrK-0002xH-KG for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:08:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCOrH-0005p5-E6 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:08:10 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:34250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCOrH-0005oc-8e for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:08:07 -0400 Received: by wgfr2 with SMTP id r2so6854102wgf.1 for ; Tue, 07 Jul 2015 02:08:06 -0700 (PDT) Message-ID: <559B96E2.2000308@linaro.org> Date: Tue, 07 Jul 2015 11:07:46 +0200 From: Eric Auger MIME-Version: 1.0 References: <1434470874-22573-1-git-send-email-eric.auger@linaro.org> <5587D4AC.1050203@linaro.org> <5587D8DE.3060208@redhat.com> <5587DA3B.60702@linaro.org> <5587DB14.1000207@redhat.com> <5587DC61.60700@linaro.org> <559B9511.5060701@linaro.org> <559B95A0.6090208@redhat.com> In-Reply-To: <559B95A0.6090208@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , eric.auger@st.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com Cc: christoffer.dall@linaro.org, patches@linaro.org On 07/07/2015 11:02 AM, Paolo Bonzini wrote: > > > On 07/07/2015 11:00, Eric Auger wrote: >> Hi Paolo, Peter, >> On 06/22/2015 11:58 AM, Eric Auger wrote: >>> On 06/22/2015 11:53 AM, Paolo Bonzini wrote: >>>> >>>> >>>> On 22/06/2015 11:49, Eric Auger wrote: >>>>>>> It seems safe because rom_load_all really doesn't load anything, it only >>>>>>> does an overlap check. Is this right? >>>>> it does the check + isrom field setting >>>>>>> >>>>>>> Is the bug that some overlapping ROMs are not detected? The commit >>>>>>> message is not clear. >>>>> The regression is that the both overlap check and isrom setting are not >>>>> done since ROM are inserted in the roms list afterwards, at machine init >>>>> done time. The bug was not really observed yet I think. >>>> >>>> isrom is just an optimization though, right? What is it useful for? >>> My understanding is it serves 2 purposes: >>> >>> - report info in the monitor (hmp_info_roms) >>> - decide whether the rom->data can be freed on ROM reset notifier >>> (rom_reset). >>> >>> Hope I didn't miss anything else. >>> >>> Eric >> >> What do we decide then about this regression on arm. Do we fix it in 2.4 >> or later? > > Yes, it should be fixed in 2.4. Do you want me to resend it with a new commit message or is the context clearer now? Thanks Eric > > Paolo >