From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48943)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZCQ0g-00087a-AR
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 06:21:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZCQ0f-0004vt-3b
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 06:21:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57711)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZCQ0e-0004ur-OU
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 06:21:53 -0400
References: <1435924905-8926-1-git-send-email-den@openvz.org>
	<1435924905-8926-13-git-send-email-den@openvz.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <559BA83C.6050702@redhat.com>
Date: Tue, 7 Jul 2015 12:21:48 +0200
MIME-Version: 1.0
In-Reply-To: <1435924905-8926-13-git-send-email-den@openvz.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/12] i386/kvm: Hyper-v crash msrs
 set/get'ers and migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Andrey Smetanin <asmetanin@virtuozzo.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>



On 03/07/2015 14:01, Denis V. Lunev wrote:
> @@ -904,6 +905,7 @@ typedef struct CPUX86State {
>      uint64_t msr_hv_guest_os_id;
>      uint64_t msr_hv_vapic;
>      uint64_t msr_hv_tsc;
> +    uint64_t msr_hv_crash_prm[HV_X64_MSR_CRASH_PARAMS];

Do not abbreviate variable names!  The enum even says PARAMS, so use
params in the array name as well.

I've done the change locally in all files.

Paolo

>      /* exception/interrupt handling */
>      int error_code;