Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0

[Olga Krishtal <okrishtal@parallels.com>]

On 07/07/15 13:32, Peter Maydell wrote:
> On 7 July 2015 at 05:40, Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
>> Hi Peter,
>>
>> Sorry for the last minute pull. This is a round-up of all tested/reviewed
>> qemu-ga patches posted prior to soft-freeze, along with 1 bug fix that
>> came in last week.
>>
>> This adds win32 implementations of:
>>    guest-get-fsinfo
>>    guest-network-get-interfaces
>>
>> and modifies guest-fstrim to return per-mount results and continue on to other
>> mounts even when a failure is encountered.
>>
>> There's also bug fixes for guest-fstrim and guest-set-time.
>>
>> The following changes since commit 7edd8e4660beb301d527257f8e04ebec0f841cb0:
>>
>>    Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-07-06 14:03:44 +0100)
>>
>> are available in the git repository at:
>>
>>
>>    git://github.com/mdroth/qemu.git tags/qga-pull-2015-07-06-tag
>>
>> for you to fetch changes up to d1ad92aab4a9419538b7b1b7423a8a770c7a2859:
>>
>>    qga: added GuestPCIAddress information (2015-07-06 23:06:12 -0500)
>>
>> ----------------------------------------------------------------
>> tag for qga-pull-2015-07-06
> Hi. I'm afraid this doesn't build for me for Windows:
>
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:21:22:
> error: ws2ipdef.h: No such file or directory
>    CC    qga/vss-win32.o
>    CC    qga/qapi-generated/qga-qapi-types.o
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:25:22:
> error: ntddscsi.h: No such file or directory
I am using the following mingw cross
[gray_pig@gray qemu]$ rpm -qf 
/usr/x86_64-w64-mingw32/sys-root/mingw/include/ntddscsi.h
mingw64-headers-4.0.2-1.el7.noarch

Do we have minimal version which should be supported for the
case? If so, should we use config option for this or bump
minimal version?

IMHO this is the root of all problems below.
>    CC    qga/qapi-generated/qga-qapi-visit.o
>    CC    qga/qapi-generated/qga-qmp-marshal.o
> cc1: warnings being treated as errors
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:39:
> warning: ‘GUID_DEVINTERFACE_VOLUME’ initialized and declared ‘extern’
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:101: error:
> expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘win2qemu’
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:124: error:
> expected ‘)’ before ‘bus’
>    AR    libqemuutil.a
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c: In
> function ‘get_disk_bus_type’:
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:526: error:
> ‘STORAGE_PROPERTY_QUERY’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:526: error:
> (Each undeclared identifier is reported only once
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:526: error:
> for each function it appears in.)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:526: error:
> expected ‘;’ before ‘query’
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:527: error:
> ‘STORAGE_DEVICE_DESCRIPTOR’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:527: error:
> ‘dev_desc’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:527: error:
> ‘buf’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:527:
> warning: left-hand operand of comma expression has no effect
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:532: error:
> ‘query’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:532: error:
> ‘StorageDeviceProperty’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:533: error:
> ‘PropertyStandardQuery’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:535: error:
> ‘IOCTL_STORAGE_QUERY_PROPERTY’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:543:
> warning: control reaches end of non-void function
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c: In
> function ‘build_guest_disk_info’:
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:552: error:
> ‘SCSI_ADDRESS’ undeclared (first use in this function)
>
To link the part of code connected with setupapi we use -lsetupapi option.
It seems you are missing this lib.
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:552: error:
> expected ‘;’ before ‘addr’
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:557: error:
> ‘scsi_ad’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:557: error:
> ‘addr’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:573:
> warning: implicit declaration of function ‘find_bus_type’
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:573:
> warning: nested extern declaration of ‘find_bus_type’
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:574: error:
> ‘BusTypeScsi’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:574: error:
> ‘BusTypeAta’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:574: error:
> ‘BusTypeRAID’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:583: error:
> ‘IOCTL_SCSI_GET_ADDRESS’ undeclared (first use in this function)
> make: *** [qga/commands-win32.o] Error 1
>
> thanks
> -- PMM
>