From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Xu Wang <gesaint@linux.vnet.ibm.com>,
jfrei@linux.vnet.ibm.com,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests
Date: Tue, 07 Jul 2015 16:22:02 +0200 [thread overview]
Message-ID: <559BE08A.9010305@de.ibm.com> (raw)
In-Reply-To: <CAEgOgz7e_ANYXE3qiBF6ef3zpa=q0HbxQOveUKC8HAXMgANg2Q@mail.gmail.com>
Am 07.07.2015 um 12:51 schrieb Peter Crosthwaite:
>> qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n");
>> @@ -80,6 +87,7 @@ static void wdt_diag288_realize(DeviceState *dev, Error **errp)
>> {
>> DIAG288State *diag288 = DIAG288(dev);
>>
>> + qemu_register_reset(diag288_reset, diag288);
>
> Doesn't seem right. Even if it is not a SBD it should still sit in the
> QOM tree in a place where the reset is reached. Where is this device
> in the QOM tree?
Hmm, to me it seems that qemu_devices_reset does only work for devices
on a bus. This is a busless-device so the reset function gets not triggered.
>
> I.E. What string do you get with an object_get_canonical_path() of the
> obj after machine init?
path /machine/peripheral/watchdog0
next prev parent reply other threads:[~2015-07-07 14:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 8:53 [Qemu-devel] [PATCH for-2.4] s390x: diag288 reset fix Cornelia Huck
2015-07-07 8:53 ` [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests Cornelia Huck
2015-07-07 10:29 ` Christian Borntraeger
2015-07-07 10:51 ` Peter Crosthwaite
2015-07-07 14:22 ` Christian Borntraeger [this message]
2015-07-07 21:11 ` Peter Crosthwaite
2015-07-08 7:45 ` Cornelia Huck
2015-07-08 10:31 ` Cornelia Huck
2015-07-09 12:41 ` Cornelia Huck
2015-07-09 16:16 ` Peter Crosthwaite
2015-07-14 13:51 ` Peter Maydell
2015-07-07 14:22 ` Cornelia Huck
2015-07-08 7:54 ` Paolo Bonzini
2015-07-08 8:01 ` Christian Borntraeger
2015-07-08 8:44 ` Paolo Bonzini
2015-07-08 8:48 ` Christian Borntraeger
2015-07-08 9:59 ` Paolo Bonzini
2015-07-14 13:33 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559BE08A.9010305@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=gesaint@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).