From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZCTlC-0006mR-Mb
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:22:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZCTl9-000125-75
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:22:10 -0400
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:37214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZCTl8-00011N-TH
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:22:07 -0400
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Tue, 7 Jul 2015 15:22:05 +0100
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B3D9817D8056
	for <qemu-devel@nongnu.org>; Tue,  7 Jul 2015 15:23:18 +0100 (BST)
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t67EM33e31129808
	for <qemu-devel@nongnu.org>; Tue, 7 Jul 2015 14:22:03 GMT
Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t67EM2fm002342
	for <qemu-devel@nongnu.org>; Tue, 7 Jul 2015 08:22:02 -0600
Message-ID: <559BE08A.9010305@de.ibm.com>
Date: Tue, 07 Jul 2015 16:22:02 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1436259202-20509-1-git-send-email-cornelia.huck@de.ibm.com>
	<1436259202-20509-2-git-send-email-cornelia.huck@de.ibm.com>
	<CAEgOgz7e_ANYXE3qiBF6ef3zpa=q0HbxQOveUKC8HAXMgANg2Q@mail.gmail.com>
In-Reply-To: <CAEgOgz7e_ANYXE3qiBF6ef3zpa=q0HbxQOveUKC8HAXMgANg2Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly
 register for system reset requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Xu Wang <gesaint@linux.vnet.ibm.com>, jfrei@linux.vnet.ibm.com, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

Am 07.07.2015 um 12:51 schrieb Peter Crosthwaite:
>>      qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n");
>> @@ -80,6 +87,7 @@ static void wdt_diag288_realize(DeviceState *dev, Error **errp)
>>  {
>>      DIAG288State *diag288 = DIAG288(dev);
>>
>> +    qemu_register_reset(diag288_reset, diag288);
> 
> Doesn't seem right. Even if it is not a SBD it should still sit in the
> QOM tree in a place where the reset is reached. Where is this device
> in the QOM tree?

Hmm, to me it seems that qemu_devices_reset does only work for devices
on a bus. This is a busless-device so the reset function gets not triggered.


> 
> I.E. What string do you get with an object_get_canonical_path() of the
> obj after machine init?


path /machine/peripheral/watchdog0