From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZCTrW-0006AP-9p
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:28:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZCTrT-0005Gw-Kc
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:28:42 -0400
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:34716)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZCTrT-0005Gl-Cz
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:28:39 -0400
Received: by wifm2 with SMTP id m2so61403568wif.1
	for <qemu-devel@nongnu.org>; Tue, 07 Jul 2015 07:28:37 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <20150707133055.11808.93250.stgit@PASHA-ISP.def.inno>
	<20150707133103.11808.63205.stgit@PASHA-ISP.def.inno>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <559BE207.2070204@twiddle.net>
Date: Tue, 7 Jul 2015 15:28:23 +0100
MIME-Version: 1.0
In-Reply-To: <20150707133103.11808.63205.stgit@PASHA-ISP.def.inno>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 01/10] softmmu: add helper function to
 pass through retaddr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, leon.alrae@imgtec.com, agraf@suse.de, aurelien@aurel32.net

On 07/07/2015 02:31 PM, Pavel Dovgalyuk wrote:
> This patch introduces several helpers to pass return address
> which points to the TB. Correct return address allows correct
> restoring of the guest PC and icount. These functions should be used when
> helpers embedded into TB invoke memory operations.
>
> Reviewed-by: Aurelien Jarno<aurelien@aurel32.net>
>
> Signed-off-by: Pavel Dovgalyuk<pavel.dovgaluk@ispras.ru>
> ---
>   include/exec/cpu_ldst_template.h          |   59 +++++++++++++++++++++++++----
>   include/exec/cpu_ldst_useronly_template.h |   25 ++++++++++++
>   softmmu_template.h                        |    6 ---
>   tcg/tcg.h                                 |   23 +++++++++++
>   4 files changed, 99 insertions(+), 14 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~