From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCUI9-0003XH-IW for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:56:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCUI5-00079J-KG for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:56:13 -0400 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]:36152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCUI5-00078R-DB for qemu-devel@nongnu.org; Tue, 07 Jul 2015 10:56:09 -0400 Received: by pacgz10 with SMTP id gz10so40857951pac.3 for ; Tue, 07 Jul 2015 07:56:07 -0700 (PDT) Message-ID: <559BE88A.2050704@gmail.com> Date: Tue, 07 Jul 2015 22:56:10 +0800 From: Wen Congyang MIME-Version: 1.0 References: <1436274549-28826-1-git-send-email-quintela@redhat.com> <1436274549-28826-25-git-send-email-quintela@redhat.com> In-Reply-To: <1436274549-28826-25-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 24/28] migration: Make events a capability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com At 2015/7/7 21:09, Juan Quintela Wrote: > Make check fails with events. THis is due to the parser/lexer that it > uses. Just in case that they are more broken parsers, just only send > events when there are capabilities. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 1 + > migration/migration.c | 20 ++++++++++++++++++-- > qapi-schema.json | 5 ++++- > 3 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index a308ecc..b2711ef 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -177,6 +177,7 @@ bool migrate_use_compression(void); > int migrate_compress_level(void); > int migrate_compress_threads(void); > int migrate_decompress_threads(void); > +bool migrate_use_events(void); > > void ram_control_before_iterate(QEMUFile *f, uint64_t flags); > void ram_control_after_iterate(QEMUFile *f, uint64_t flags); > diff --git a/migration/migration.c b/migration/migration.c > index d8415c4..cd32eac 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -205,6 +205,14 @@ void register_global_state(void) > vmstate_register(NULL, 0, &vmstate_globalstate, &global_state); > } > > +static void migrate_generate_event(int new_state) > +{ > + if (migrate_use_events()) { > + qapi_event_send_migration(new_state, &error_abort); > + trace_migrate_set_state(new_state); > + } > +} > + > /* > * Called on -incoming with a defer: uri. > * The migration can be started later after any parameters have been > @@ -511,8 +519,7 @@ void qmp_migrate_set_parameters(bool has_compress_level, > static void migrate_set_state(MigrationState *s, int old_state, int new_state) > { > if (atomic_cmpxchg(&s->state, old_state, new_state) == old_state) { > - qapi_event_send_migration(new_state, &error_abort); > - trace_migrate_set_state(new_state); > + migrate_generate_event(new_state); Why moving trace_* to migrate_generate_event()? trace event should be controlled by the monitor command trace-event xxx on/off. It is very strange if the user turns the trace event on, but gets no output. Thanks Wen Congyang > } > } > > @@ -862,6 +869,15 @@ int migrate_decompress_threads(void) > return s->parameters[MIGRATION_PARAMETER_DECOMPRESS_THREADS]; > } > > +bool migrate_use_events(void) > +{ > + MigrationState *s; > + > + s = migrate_get_current(); > + > + return s->enabled_capabilities[MIGRATION_CAPABILITY_EVENTS]; > +} > + > int migrate_use_xbzrle(void) > { > MigrationState *s; > diff --git a/qapi-schema.json b/qapi-schema.json > index 106008c..1285b8c 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -523,6 +523,9 @@ > # minimize migration traffic. The feature is disabled by default. > # (since 2.4 ) > # > +# @events: generate events for each migration state change > +# (since 2.4 ) > +# > # @auto-converge: If enabled, QEMU will automatically throttle down the guest > # to speed up convergence of RAM migration. (since 1.6) > # > @@ -530,7 +533,7 @@ > ## > { 'enum': 'MigrationCapability', > 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks', > - 'compress'] } > + 'compress', 'events'] } > > ## > # @MigrationCapabilityStatus >