From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCgh2-0002TH-3c for qemu-devel@nongnu.org; Wed, 08 Jul 2015 00:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCggw-0006Gv-IS for qemu-devel@nongnu.org; Wed, 08 Jul 2015 00:10:44 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:35936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCggw-0006FY-Cg for qemu-devel@nongnu.org; Wed, 08 Jul 2015 00:10:38 -0400 Received: by pddu5 with SMTP id u5so50285142pdd.3 for ; Tue, 07 Jul 2015 21:10:37 -0700 (PDT) References: <1436327021-14744-1-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <559CA2B4.3090303@ozlabs.ru> Date: Wed, 8 Jul 2015 14:10:28 +1000 MIME-Version: 1.0 In-Reply-To: <1436327021-14744-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, abologna@redhat.com, qemu-ppc@nongnu.org, mdroth@linuc.vnet.ibm.com, afaerber@suse.de On 07/08/2015 01:43 PM, David Gibson wrote: > From: Andrea Bolognani > > Add a missing PVR value for the POWER8E v2.1 CPU. Information taken > from the kernel cputable. > > Signed-off-by: Andrea Bolognani > Signed-off-by: David Gibson > --- > target-ppc/cpu-models.c | 4 +++- > target-ppc/cpu-models.h | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > Alex, > > Not sure if this counts as a bugfix which can be merged now we're in > the hard freeze. The lack of it does mean we can't work on one of our > dev machines which has this CPU. Why is this a stopper? We stopped bothering with exact PVRs some time ago and -cpu POWER8 or -cpu host still work. > > diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c > index 4d5ab4b..9d8769b 100644 > --- a/target-ppc/cpu-models.c > +++ b/target-ppc/cpu-models.c > @@ -1140,6 +1140,8 @@ > "POWER7+ v2.1") > POWERPC_DEF("POWER8E_v1.0", CPU_POWERPC_POWER8E_v10, POWER8, > "POWER8E v1.0") > + POWERPC_DEF("POWER8E_v2.1", CPU_POWERPC_POWER8E_v21, POWER8, > + "POWER8E v2.1") > POWERPC_DEF("POWER8_v1.0", CPU_POWERPC_POWER8_v10, POWER8, > "POWER8 v1.0") > POWERPC_DEF("970_v2.2", CPU_POWERPC_970_v22, 970, > @@ -1389,7 +1391,7 @@ PowerPCCPUAlias ppc_cpu_aliases[] = { > { "POWER5gs", "POWER5+_v2.1" }, > { "POWER7", "POWER7_v2.3" }, > { "POWER7+", "POWER7+_v2.1" }, > - { "POWER8E", "POWER8E_v1.0" }, > + { "POWER8E", "POWER8E_v2.1" }, > { "POWER8", "POWER8_v1.0" }, > { "970", "970_v2.2" }, > { "970fx", "970fx_v3.1" }, > diff --git a/target-ppc/cpu-models.h b/target-ppc/cpu-models.h > index 9d80e72..add31c6 100644 > --- a/target-ppc/cpu-models.h > +++ b/target-ppc/cpu-models.h > @@ -558,6 +558,7 @@ enum { > CPU_POWERPC_POWER7P_v21 = 0x004A0201, > CPU_POWERPC_POWER8E_BASE = 0x004B0000, > CPU_POWERPC_POWER8E_v10 = 0x004B0100, > + CPU_POWERPC_POWER8E_v21 = 0x004B0201, > CPU_POWERPC_POWER8_BASE = 0x004D0000, > CPU_POWERPC_POWER8_v10 = 0x004D0100, > CPU_POWERPC_970_v22 = 0x00390202, > -- Alexey