From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCj29-0007mZ-SY for qemu-devel@nongnu.org; Wed, 08 Jul 2015 02:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCj24-0008Rx-Q6 for qemu-devel@nongnu.org; Wed, 08 Jul 2015 02:40:41 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCj24-0008RW-BF for qemu-devel@nongnu.org; Wed, 08 Jul 2015 02:40:36 -0400 Received: by pdbep18 with SMTP id ep18so140041051pdb.1 for ; Tue, 07 Jul 2015 23:40:35 -0700 (PDT) References: <1436327021-14744-1-git-send-email-david@gibson.dropbear.id.au> <559CA2B4.3090303@ozlabs.ru> <20150708053708.GN17857@voom.redhat.com> From: Alexey Kardashevskiy Message-ID: <559CC5DB.2030407@ozlabs.ru> Date: Wed, 8 Jul 2015 16:40:27 +1000 MIME-Version: 1.0 In-Reply-To: <20150708053708.GN17857@voom.redhat.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, qemu-ppc@nongnu.org, abologna@redhat.com, mdroth@linuc.vnet.ibm.com, afaerber@suse.de On 07/08/2015 03:37 PM, David Gibson wrote: > On Wed, Jul 08, 2015 at 02:10:28PM +1000, Alexey Kardashevskiy wrote: >> On 07/08/2015 01:43 PM, David Gibson wrote: >>> From: Andrea Bolognani >>> >>> Add a missing PVR value for the POWER8E v2.1 CPU. Information taken >> >from the kernel cputable. >>> >>> Signed-off-by: Andrea Bolognani >>> Signed-off-by: David Gibson >>> --- >>> target-ppc/cpu-models.c | 4 +++- >>> target-ppc/cpu-models.h | 1 + >>> 2 files changed, 4 insertions(+), 1 deletion(-) >>> >>> Alex, >>> >>> Not sure if this counts as a bugfix which can be merged now we're in >>> the hard freeze. The lack of it does mean we can't work on one of our >>> dev machines which has this CPU. >> >> >> Why is this a stopper? We stopped bothering with exact PVRs some time ago >> and -cpu POWER8 or -cpu host still work. > > Andrea, can you clarify? > > I think it's because libvirt likes to specify a specific CPU - and if > it gets the new PVR from the host, qemu won't understand it. A specific CPU in this case is "POWER8", I added this specifically for libvirt (to allow migration between all versions of POWER8), it should not use versioned CPUs and it does not in powerkvm. There is actually a patch to make this PVR masking/subclassing nicer, I replied to it with adding you in cc:, please have a look. Andreas Faerber had objections which I did not really grasp then. -- Alexey