From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZCk9f-00061z-HM
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 03:52:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZCk9c-0002OX-Ct
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 03:52:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46481)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZCk9c-0002Nr-7H
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 03:52:28 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id E213E371B78
	for <qemu-devel@nongnu.org>; Wed,  8 Jul 2015 07:52:26 +0000 (UTC)
References: <1424449612-18215-1-git-send-email-pbonzini@redhat.com>
	<1424449612-18215-3-git-send-email-pbonzini@redhat.com>
	<20150708021832.GG10382@ad.nay.redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <559CD6B7.9070103@redhat.com>
Date: Wed, 8 Jul 2015 09:52:23 +0200
MIME-Version: 1.0
In-Reply-To: <20150708021832.GG10382@ad.nay.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] AioContext: acquire/release AioContext
 during aio_poll
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org

On 08/07/2015 04:18, Fam Zheng wrote:
>> > @@ -267,7 +268,13 @@ bool aio_poll(AioContext *ctx, bool blocking)
>> >      timeout = blocking ? aio_compute_timeout(ctx) : 0;
>> >  
>> >      /* wait until next event */
>> > +    if (timeout) {
>> > +        aio_context_release(ctx);
>> > +    }
>> >      ret = qemu_poll_ns((GPollFD *)pollfds, npfd, timeout);
> If two threads poll concurrently on this ctx, they will get the same set of
> events, is that safe? Doesn't that lead to double dispatch?

Yes, but handlers should be okay with spurious wakeup.  They will just
get EAGAIN.

Paolo