From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCkyJ-0003ws-7P for qemu-devel@nongnu.org; Wed, 08 Jul 2015 04:44:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCkyE-0006nI-63 for qemu-devel@nongnu.org; Wed, 08 Jul 2015 04:44:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCkyE-0006mI-0U for qemu-devel@nongnu.org; Wed, 08 Jul 2015 04:44:46 -0400 References: <1436259202-20509-1-git-send-email-cornelia.huck@de.ibm.com> <1436259202-20509-2-git-send-email-cornelia.huck@de.ibm.com> <559CD740.1020201@redhat.com> <559CD8D8.20604@de.ibm.com> From: Paolo Bonzini Message-ID: <559CE2F8.7040602@redhat.com> Date: Wed, 8 Jul 2015 10:44:40 +0200 MIME-Version: 1.0 In-Reply-To: <559CD8D8.20604@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Peter Crosthwaite , Cornelia Huck Cc: Xu Wang , jfrei@linux.vnet.ibm.com, "qemu-devel@nongnu.org Developers" , Alexander Graf On 08/07/2015 10:01, Christian Borntraeger wrote: > > > Doesn't seem right. Even if it is not a SBD it should still sit in the > > > QOM tree in a place where the reset is reached. Where is this device > > > in the QOM tree? > > > > Reset doesn't follow the QOM tree. > > > > In fact this is the main reason why I dislike TYPE_DEVICE as a superclass... > > Oh, thats why we were asked to use that instead of sysbus device? ;-) Did I? I've always liked sysbus... :) Paolo