From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Xu Wang <gesaint@linux.vnet.ibm.com>,
jfrei@linux.vnet.ibm.com,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests
Date: Wed, 08 Jul 2015 10:48:05 +0200 [thread overview]
Message-ID: <559CE3C5.8020703@de.ibm.com> (raw)
In-Reply-To: <559CE2F8.7040602@redhat.com>
Am 08.07.2015 um 10:44 schrieb Paolo Bonzini:
>
>
> On 08/07/2015 10:01, Christian Borntraeger wrote:
>>>> Doesn't seem right. Even if it is not a SBD it should still sit in the
>>>> QOM tree in a place where the reset is reached. Where is this device
>>>> in the QOM tree?
>>>
>>> Reset doesn't follow the QOM tree.
>>>
>>> In fact this is the main reason why I dislike TYPE_DEVICE as a superclass...
>>
>> Oh, thats why we were asked to use that instead of sysbus device? ;-)
>
> Did I? I've always liked sysbus... :)
Not you.
But its a pattern that I have seen 3 or 4 times: "Oh no, please do not
use xxx any more, we have fancy new stuff that nobody else is using in the tree,
but its the way to go..." But most of the time the hickups can be handled. :-)
Christian
next prev parent reply other threads:[~2015-07-08 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 8:53 [Qemu-devel] [PATCH for-2.4] s390x: diag288 reset fix Cornelia Huck
2015-07-07 8:53 ` [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests Cornelia Huck
2015-07-07 10:29 ` Christian Borntraeger
2015-07-07 10:51 ` Peter Crosthwaite
2015-07-07 14:22 ` Christian Borntraeger
2015-07-07 21:11 ` Peter Crosthwaite
2015-07-08 7:45 ` Cornelia Huck
2015-07-08 10:31 ` Cornelia Huck
2015-07-09 12:41 ` Cornelia Huck
2015-07-09 16:16 ` Peter Crosthwaite
2015-07-14 13:51 ` Peter Maydell
2015-07-07 14:22 ` Cornelia Huck
2015-07-08 7:54 ` Paolo Bonzini
2015-07-08 8:01 ` Christian Borntraeger
2015-07-08 8:44 ` Paolo Bonzini
2015-07-08 8:48 ` Christian Borntraeger [this message]
2015-07-08 9:59 ` Paolo Bonzini
2015-07-14 13:33 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559CE3C5.8020703@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=gesaint@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).