From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZCl1c-0005O7-1f
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 04:48:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZCl1W-0000CB-UZ
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 04:48:16 -0400
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:47388)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZCl1W-0000Bl-L2
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 04:48:10 -0400
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Wed, 8 Jul 2015 09:48:07 +0100
Received: from b06cxnps4076.portsmouth.uk.ibm.com
	(d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1777B219004D
	for <qemu-devel@nongnu.org>; Wed,  8 Jul 2015 09:47:44 +0100 (BST)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t688m6sJ11927628
	for <qemu-devel@nongnu.org>; Wed, 8 Jul 2015 08:48:06 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t683f1hM017553
	for <qemu-devel@nongnu.org>; Tue, 7 Jul 2015 23:41:01 -0400
Message-ID: <559CE3C5.8020703@de.ibm.com>
Date: Wed, 08 Jul 2015 10:48:05 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1436259202-20509-1-git-send-email-cornelia.huck@de.ibm.com>
	<1436259202-20509-2-git-send-email-cornelia.huck@de.ibm.com>
	<CAEgOgz7e_ANYXE3qiBF6ef3zpa=q0HbxQOveUKC8HAXMgANg2Q@mail.gmail.com>
	<559CD740.1020201@redhat.com> <559CD8D8.20604@de.ibm.com>
	<559CE2F8.7040602@redhat.com>
In-Reply-To: <559CE2F8.7040602@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly
 register for system reset requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Xu Wang <gesaint@linux.vnet.ibm.com>, jfrei@linux.vnet.ibm.com, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

Am 08.07.2015 um 10:44 schrieb Paolo Bonzini:
> 
> 
> On 08/07/2015 10:01, Christian Borntraeger wrote:
>>>> Doesn't seem right. Even if it is not a SBD it should still sit in the
>>>> QOM tree in a place where the reset is reached. Where is this device
>>>> in the QOM tree?
>>>
>>> Reset doesn't follow the QOM tree.
>>>
>>> In fact this is the main reason why I dislike TYPE_DEVICE as a superclass...
>>
>> Oh, thats why we were asked to use that instead of sysbus device? ;-)
> 
> Did I?  I've always liked sysbus... :)

Not you.
But its a pattern that I have seen 3 or 4 times: "Oh no, please do not
use xxx any more, we have fancy new stuff that nobody else is using in the tree,
but its the way to go..." But  most of the time the hickups can be handled. :-)

Christian