From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCm1j-00046u-Rf for qemu-devel@nongnu.org; Wed, 08 Jul 2015 05:52:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCm1f-0002mK-ID for qemu-devel@nongnu.org; Wed, 08 Jul 2015 05:52:27 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:56825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCm1e-0002jj-OB for qemu-devel@nongnu.org; Wed, 08 Jul 2015 05:52:23 -0400 Message-ID: <559CF016.4040101@huawei.com> Date: Wed, 8 Jul 2015 17:40:38 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1436274549-28826-1-git-send-email-quintela@redhat.com> <1436274549-28826-15-git-send-email-quintela@redhat.com> In-Reply-To: <1436274549-28826-15-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 14/28] runstate: migration allows more transitions now List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, peter.huangpeng@huawei.com Hi, If testing migration with '-S' for qemu command line, (migrate directly without executing 'cont' command), qemu process in the destination will abort with the follow message: ERROR: invalid runstate transition: 'inmigrate' -> 'prelaunch' Aborted After the follow modification, it will be OK. Is this need to be fix ? --- a/vl.c +++ b/vl.c @@ -583,6 +583,7 @@ static const RunStateTransition runstate_transitions_def[] = { { RUN_STATE_INMIGRATE, RUN_STATE_WATCHDOG }, { RUN_STATE_INMIGRATE, RUN_STATE_GUEST_PANICKED }, + { RUN_STATE_INMIGRATE, RUN_STATE_PRELAUNCH }, { RUN_STATE_INTERNAL_ERROR, RUN_STATE_PAUSED }, { RUN_STATE_INTERNAL_ERROR, RUN_STATE_FINISH_MIGRATE }, Thanks, zhanghailiang On 2015/7/7 21:08, Juan Quintela wrote: > Next commit would allow to move from incoming migration to error happening on source. > > Should we add more states to this transition? Luiz? > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > --- > vl.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/vl.c b/vl.c > index fec7e93..19a8737 100644 > --- a/vl.c > +++ b/vl.c > @@ -573,8 +573,14 @@ static const RunStateTransition runstate_transitions_def[] = { > { RUN_STATE_DEBUG, RUN_STATE_RUNNING }, > { RUN_STATE_DEBUG, RUN_STATE_FINISH_MIGRATE }, > > - { RUN_STATE_INMIGRATE, RUN_STATE_RUNNING }, > + { RUN_STATE_INMIGRATE, RUN_STATE_INTERNAL_ERROR }, > + { RUN_STATE_INMIGRATE, RUN_STATE_IO_ERROR }, > { RUN_STATE_INMIGRATE, RUN_STATE_PAUSED }, > + { RUN_STATE_INMIGRATE, RUN_STATE_RUNNING }, > + { RUN_STATE_INMIGRATE, RUN_STATE_SHUTDOWN }, > + { RUN_STATE_INMIGRATE, RUN_STATE_SUSPENDED }, > + { RUN_STATE_INMIGRATE, RUN_STATE_WATCHDOG }, > + { RUN_STATE_INMIGRATE, RUN_STATE_GUEST_PANICKED }, > > { RUN_STATE_INTERNAL_ERROR, RUN_STATE_PAUSED }, > { RUN_STATE_INTERNAL_ERROR, RUN_STATE_FINISH_MIGRATE }, >