From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCmRq-0007g3-Jt for qemu-devel@nongnu.org; Wed, 08 Jul 2015 06:19:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCmRl-0001Bw-AL for qemu-devel@nongnu.org; Wed, 08 Jul 2015 06:19:26 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:52267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCmRk-0001BX-WC for qemu-devel@nongnu.org; Wed, 08 Jul 2015 06:19:21 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Jul 2015 11:19:20 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id C1A1917D8056 for ; Wed, 8 Jul 2015 11:20:34 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t68AJIPZ33685750 for ; Wed, 8 Jul 2015 10:19:18 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t68AJI90024297 for ; Wed, 8 Jul 2015 04:19:18 -0600 Message-ID: <559CF926.2040001@de.ibm.com> Date: Wed, 08 Jul 2015 12:19:18 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1436274549-28826-1-git-send-email-quintela@redhat.com> <1436274549-28826-16-git-send-email-quintela@redhat.com> <559CF767.3060000@de.ibm.com> <20150708101415.GD2463@work-vm> In-Reply-To: <20150708101415.GD2463@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 15/28] migration: create new section to store global state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, Cornelia Huck , qemu-devel@nongnu.org, Juan Quintela Am 08.07.2015 um 12:14 schrieb Dr. David Alan Gilbert: > * Christian Borntraeger (borntraeger@de.ibm.com) wrote: >> Am 07.07.2015 um 15:08 schrieb Juan Quintela: >>> This includes a new section that for now just stores the current qemu state. >>> >>> Right now, there are only one way to control what is the state of the >>> target after migration. >>> >>> - If you run the target qemu with -S, it would start stopped. >>> - If you run the target qemu without -S, it would run just after migration finishes. >>> >>> The problem here is what happens if we start the target without -S and >>> there happens one error during migration that puts current state as >>> -EIO. Migration would ends (notice that the error happend doing block >>> IO, network IO, i.e. nothing related with migration), and when >>> migration finish, we would just "continue" running on destination, >>> probably hanging the guest/corruption data, whatever. >>> >>> Signed-off-by: Juan Quintela >>> Reviewed-by: Dr. David Alan Gilbert >> >> This is bisected to cause a regression on s390. >> >> A guest restarts (booting) after managedsave/start instead of continuing. >> >> Do you have any idea what might be wrong? > > I'd add some debug to the pre_save and post_load to see what state value is > being saved/restored. migrate_global_state_pre_save saved state: paused migrate_global_state_post_load loaded state: paused > Also, does that regression happen when doing the save/restore using the same/latest > git, or is it a load from an older version? It the same git that fails.