From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCtMZ-0006JQ-P4 for qemu-devel@nongnu.org; Wed, 08 Jul 2015 13:42:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCtMW-0001QE-HM for qemu-devel@nongnu.org; Wed, 08 Jul 2015 13:42:27 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:36962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCtMW-0001PP-8l for qemu-devel@nongnu.org; Wed, 08 Jul 2015 13:42:24 -0400 Received: by wiclp1 with SMTP id lp1so87562920wic.0 for ; Wed, 08 Jul 2015 10:42:23 -0700 (PDT) Sender: Paolo Bonzini References: <1436348808-223033-1-git-send-email-imammedo@redhat.com> <1436348808-223033-8-git-send-email-imammedo@redhat.com> <20150708165837.62857513@igors-macbook-pro.local> From: Paolo Bonzini Message-ID: <559D60FD.7010500@redhat.com> Date: Wed, 8 Jul 2015 19:42:21 +0200 MIME-Version: 1.0 In-Reply-To: <20150708165837.62857513@igors-macbook-pro.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v3 7/8] memory: extend memory_region_add_subregion() to support error reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Peter Maydell Cc: QEMU Developers , "Michael S. Tsirkin" On 08/07/2015 16:58, Igor Mammedov wrote: > I'll drop this patch in favor of dedicated > memory_region_add_subregion_to_hva() API that can fail and return error. Isn't the deletion of subregion that is done too early for your work? You don't want the hot-unplug to complete until all the address_space_unmaps have completed, if I understand correctly. Paolo