From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43351)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZCtOR-0008G7-7o
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 13:44:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZCtOO-0002Ai-0p
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 13:44:23 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:33591)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZCtON-0002Ab-OZ
	for qemu-devel@nongnu.org; Wed, 08 Jul 2015 13:44:19 -0400
Received: by wiwl6 with SMTP id l6so351891108wiw.0
	for <qemu-devel@nongnu.org>; Wed, 08 Jul 2015 10:44:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1433812331-18993-1-git-send-email-minyard@acm.org>
	<1433812331-18993-15-git-send-email-minyard@acm.org>
	<20150707100829.401476a9@nial.brq.redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <559D6170.6080804@redhat.com>
Date: Wed, 8 Jul 2015 19:44:16 +0200
MIME-Version: 1.0
In-Reply-To: <20150707100829.401476a9@nial.brq.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to
	add ACPI tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, minyard@acm.org
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org



On 07/07/2015 10:08, Igor Mammedov wrote:
> > Some devices, like IPMI, need to add ACPI table entries to report
> > their presence.  Add a method for adding these entries.
>
> I think that it's not up to device to define in which table/scope
> it's entries should be but rather upto a board/platform to decide.
> 
> I'd prefer the old way of adding device's ACPI AML into existing
> SSDT

This was suggested by Michael, so I think you should read the reviews of
earlier versions first.

Paolo

, like we do for every other device that needs it
> (for example: pvpanic).
> That allows to keep ACPI code in one place and for each platform
> to decide to which table put a device description and where exactly
> it should be.
> 
> So I'd drop this patch and add function that returns non NULL
> "IPMIFwInfo *" if IPMI device is present and use slightly modified
> 15/16 to add device entry into the existing SSDT.