From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZD5kx-00047n-TR for qemu-devel@nongnu.org; Thu, 09 Jul 2015 02:56:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZD5kt-0006SD-Sc for qemu-devel@nongnu.org; Thu, 09 Jul 2015 02:56:27 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:38499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZD5kt-0006S6-KK for qemu-devel@nongnu.org; Thu, 09 Jul 2015 02:56:23 -0400 Received: by wibdq8 with SMTP id dq8so232613003wib.1 for ; Wed, 08 Jul 2015 23:56:22 -0700 (PDT) Sender: Richard Henderson References: <1436412413-27389-1-git-send-email-crosthwaite.peter@gmail.com> From: Richard Henderson Message-ID: <559E1B10.4010205@twiddle.net> Date: Thu, 9 Jul 2015 07:56:16 +0100 MIME-Version: 1.0 In-Reply-To: <1436412413-27389-1-git-send-email-crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] cpu_defs: Simplify CPUTLB padding logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Peter Crosthwaite On 07/09/2015 04:26 AM, Peter Crosthwaite wrote: > There was a complicated subtractive arithmetic for determining the > padding on the CPUTLBEntry structure. Simplify this with a union. > > Signed-off-by: Peter Crosthwaite > --- > Changed since v1: > Remove un-needed anonymous union (Paolo review) > --- > include/exec/cpu-defs.h | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson r~