From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for feature flags
Date: Thu, 9 Jul 2015 16:15:19 +0200 [thread overview]
Message-ID: <559E81F7.30606@redhat.com> (raw)
In-Reply-To: <1429025304-17422-1-git-send-email-ehabkost@redhat.com>
On 14/04/2015 17:28, Eduardo Habkost wrote:
> + for (i = 1; names[i]; i++) {
> + feat2prop(names[i]);
> + object_property_add_alias(obj, names[i], obj, names[0], &error_abort);
The version you committed has a strdup(names[0]) here, but
object_property_add_alias already does a strdup.
Paolo
> + }
next prev parent reply other threads:[~2015-07-09 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 15:28 [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for feature flags Eduardo Habkost
2015-04-15 7:47 ` Igor Mammedov
2015-05-22 19:13 ` Eduardo Habkost
2015-07-09 14:15 ` Paolo Bonzini [this message]
2015-07-09 14:51 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E81F7.30606@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).