From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33668)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZDCbo-0002oy-0w
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 10:15:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZDCbi-0006ZH-Et
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 10:15:27 -0400
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:35825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZDCbi-0006Z2-6k
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 10:15:22 -0400
Received: by wiga1 with SMTP id a1so314308174wig.0
	for <qemu-devel@nongnu.org>; Thu, 09 Jul 2015 07:15:21 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1429025304-17422-1-git-send-email-ehabkost@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <559E81F7.30606@redhat.com>
Date: Thu, 9 Jul 2015 16:15:19 +0200
MIME-Version: 1.0
In-Reply-To: <1429025304-17422-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties
	for feature flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>



On 14/04/2015 17:28, Eduardo Habkost wrote:
> +    for (i = 1; names[i]; i++) {
> +        feat2prop(names[i]);
> +        object_property_add_alias(obj, names[i], obj, names[0], &error_abort);

The version you committed has a strdup(names[0]) here, but
object_property_add_alias already does a strdup.

Paolo

> +    }