qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	QEMU <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>,
	stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	cam <cam@cs.ualberta.ca>
Subject: Re: [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest
Date: Thu, 09 Jul 2015 17:13:20 +0200	[thread overview]
Message-ID: <559E8F90.4010502@suse.de> (raw)
In-Reply-To: <CAJ+F1CJ5O1kPZFuqcUd1eh18f70wbLySdLz4Fjvyvb3pBhhanA@mail.gmail.com>

Hi Marc-André,

Am 09.07.2015 um 16:37 schrieb Marc-André Lureau:
> On Fri, Jun 26, 2015 at 6:02 PM, Marc-André Lureau
> <marcandre.lureau@gmail.com> wrote:
>>> Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would
>>> need to depend on KVM/eventfd, and for that there is no easy config
>>> option available here, which stopped my patch at the time.
>>
>>
>> Right, I don't have good answer for that. I'd need more help.
> 
> Actually, ivshmem doesn't use ioeventfd by default. And my tests do
> not enable it either.
> 
> So the test runs fine with kvm disabled on my host. Is that enough then?
> 
> I couldn't find the discussion on "RFC: CONFIG_LINUX", do you have a pointer?

Pretty sure I pointed you to my RFC already:
http://patchwork.ozlabs.org/patch/336367/

Paolo wrote: "I think ivshmem depends on ioeventfd"
And mst suggested: "maybe it's easier to implement eventfd APIs"
Which I didn't do, and am not aware anyone else did, but maybe I missed it?

I've dug out my old patch with the tempfile name fix but didn't get to
implementing that missing query while dealing with the qom-cpu pull.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)

      reply	other threads:[~2015-07-09 15:13 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 14:49 [Qemu-devel] [PATCH 00/39] ivshmem server/client, cleanups & test Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 01/39] char: add qemu_chr_free() Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 02/39] msix: add VMSTATE_MSIX_TEST Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 03/39] ivhsmem: read do not accept more than sizeof(long) Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 04/39] ivshmem: fix number of bytes to push to fifo Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 05/39] ivshmem: factor out the incoming fifo handling Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 06/39] ivshmem: remove unnecessary dup() Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 07/39] ivshmem: remove superflous ivshmem_attr field Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 08/39] ivshmem: remove useless doorbell field Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 09/39] ivshmem: more qdev conversion Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 10/39] ivshmem: remove last exit(1) Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 11/39] ivshmem: increase_dynamic_storage() improvements Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 12/39] ivshmem: remove useless ivshmem_update_irq() val argument Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 13/39] ivshmem: initialize max_peer to -1 Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 14/39] ivshmem: remove max_peer field Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 15/39] ivshmem: improve debug messages Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 16/39] ivshmem: improve error Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 17/39] ivshmem: print error on invalid peer id Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 18/39] ivshmem: add a warning if eventfd value is 0 Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 19/39] ivshmem: beautify a bit the code Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 20/39] ivshmem: use common return Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 21/39] ivshmem: use common is_power_of_2() Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 22/39] ivshmem: migrate with VMStateDescription Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 23/39] ivshmem: shmfd can be 0 Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 24/39] ivshmem: check shm isn't already initialized Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 25/39] ivshmem: add device description Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 26/39] ivshmem: fix pci_ivshmem_exit() Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 27/39] ivshmem: replace 'guest' for 'peer' appropriately Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 28/39] ivshmem: error on too many eventfd received Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 29/39] ivshmem: reset mask on device reset Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 30/39] contrib: add ivshmem client and server Marc-André Lureau
2015-06-26 16:25   ` Andrew Jones
2015-06-29 22:25     ` Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 31/39] ivshmem-client: check the number of vectors Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 32/39] ivshmem-server: use a uint16 for client ID Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 33/39] ivshmem-server: include necessary headers Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 34/39] docs: update ivshmem device spec Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 35/39] ivshmem: add check on protocol version in QEMU Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 36/39] contrib: remove unnecessary strdup() Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 37/39] msix: implement read-only pba write Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 38/39] qtest: add qtest_add_abrt_handler() Marc-André Lureau
2015-06-26 14:49 ` [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest Marc-André Lureau
2015-06-26 15:08   ` Andreas Färber
2015-06-26 15:27     ` Marc-André Lureau
2015-06-26 15:44       ` Marc-André Lureau
2015-06-26 16:05         ` Andreas Färber
2015-06-26 15:53       ` Andreas Färber
2015-06-26 16:02         ` Marc-André Lureau
2015-06-26 16:13           ` Andreas Färber
2015-07-09 14:37           ` Marc-André Lureau
2015-07-09 15:13             ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559E8F90.4010502@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=cam@cs.ualberta.ca \
    --cc=marcandre.lureau@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).