From: "Andreas Färber" <afaerber@suse.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org
Cc: peter.crosthwaite@xilinx.com, borntraeger@de.ibm.com,
jfrei@linux.vnet.ibm.com, agraf@suse.de,
gesaint@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices
Date: Thu, 09 Jul 2015 18:59:16 +0200 [thread overview]
Message-ID: <559EA864.4070807@suse.de> (raw)
In-Reply-To: <1436460692-5142-2-git-send-email-cornelia.huck@de.ibm.com>
Am 09.07.2015 um 18:51 schrieb Cornelia Huck:
> Devices that don't live on a bus aren't caught by the normal device
> reset logic. Let's register a reset handler for those devices during
> device realization that calls the reset handler for the associated
> device class.
>
> Suggested-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/core/qdev.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
Looks acceptable as solution for 2.4... However, I would like to
understand why the parent device cannot reset it? Someone created that
device in the first place. I would prefer you call device_reset() from
there without this generic patch.
A similar discussion took place for the x86 APIC.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-07-09 16:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 16:51 [Qemu-devel] [PATCH for-2.4 0/2] reset for bus-less devices Cornelia Huck
2015-07-09 16:51 ` [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler " Cornelia Huck
2015-07-09 16:59 ` Andreas Färber [this message]
2015-07-09 18:53 ` Peter Crosthwaite
2015-07-13 14:28 ` Paolo Bonzini
2015-07-13 12:22 ` Christian Borntraeger
2015-07-13 14:11 ` Cornelia Huck
2015-07-13 14:20 ` Andreas Färber
2015-07-13 14:30 ` Christian Borntraeger
2015-07-13 15:05 ` Andreas Färber
2015-07-13 15:38 ` Cornelia Huck
2015-07-13 15:49 ` Andreas Färber
2015-07-13 15:56 ` Peter Maydell
2015-07-13 14:37 ` Cornelia Huck
2015-07-13 16:06 ` Andreas Färber
2015-07-14 7:41 ` Cornelia Huck
2015-07-09 16:51 ` [Qemu-devel] [PATCH for-2.4 2/2] watchdog/diag288: handle subsystem resets correctly Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559EA864.4070807@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gesaint@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).