From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDFAR-0006Wm-M8 for qemu-devel@nongnu.org; Thu, 09 Jul 2015 12:59:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDFAM-00075U-My for qemu-devel@nongnu.org; Thu, 09 Jul 2015 12:59:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58930 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDFAM-00075M-GX for qemu-devel@nongnu.org; Thu, 09 Jul 2015 12:59:18 -0400 Message-ID: <559EA864.4070807@suse.de> Date: Thu, 09 Jul 2015 18:59:16 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1436460692-5142-1-git-send-email-cornelia.huck@de.ibm.com> <1436460692-5142-2-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1436460692-5142-2-git-send-email-cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , qemu-devel@nongnu.org Cc: peter.crosthwaite@xilinx.com, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, agraf@suse.de, gesaint@linux.vnet.ibm.com Am 09.07.2015 um 18:51 schrieb Cornelia Huck: > Devices that don't live on a bus aren't caught by the normal device > reset logic. Let's register a reset handler for those devices during > device realization that calls the reset handler for the associated > device class. >=20 > Suggested-by: Peter Crosthwaite > Signed-off-by: Cornelia Huck > --- > hw/core/qdev.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) Looks acceptable as solution for 2.4... However, I would like to understand why the parent device cannot reset it? Someone created that device in the first place. I would prefer you call device_reset() from there without this generic patch. A similar discussion took place for the x86 APIC. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)