From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDa8D-0003zC-Ct for qemu-devel@nongnu.org; Fri, 10 Jul 2015 11:22:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDa8A-00042a-7h for qemu-devel@nongnu.org; Fri, 10 Jul 2015 11:22:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDa8A-00042U-2c for qemu-devel@nongnu.org; Fri, 10 Jul 2015 11:22:26 -0400 References: <1436541553-26576-1-git-send-email-fred.konrad@greensocs.com> <1436541553-26576-2-git-send-email-fred.konrad@greensocs.com> From: Paolo Bonzini Message-ID: <559FE32C.5030609@redhat.com> Date: Fri, 10 Jul 2015 17:22:20 +0200 MIME-Version: 1.0 In-Reply-To: <1436541553-26576-2-git-send-email-fred.konrad@greensocs.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 1/3] cpus: protect queued_work_* with work_mutex. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@greensocs.com Cc: mark.burton@greensocs.com, alex.bennee@linaro.org, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com On 10/07/2015 17:19, fred.konrad@greensocs.com wrote: > + qemu_mutex_lock(&cpu->work_mutex); > while ((wi = cpu->queued_work_first)) { > cpu->queued_work_first = wi->next; > wi->func(wi->data); Please unlock the mutex while calling the callback. Paolo > @@ -905,6 +912,8 @@ static void flush_queued_work(CPUState *cpu) > } > } > cpu->queued_work_last = NULL; > + qemu_mutex_unlock(&cpu->work_mutex); > + > qemu_cond_broadcast(&qemu_work_cond);