From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDaJA-0007oX-7T for qemu-devel@nongnu.org; Fri, 10 Jul 2015 11:33:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDaJ9-00006o-E6 for qemu-devel@nongnu.org; Fri, 10 Jul 2015 11:33:48 -0400 References: <1436384203-10576-1-git-send-email-kwolf@redhat.com> <1436384203-10576-2-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <559FE5D1.2050003@redhat.com> Date: Fri, 10 Jul 2015 17:33:37 +0200 MIME-Version: 1.0 In-Reply-To: <1436384203-10576-2-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4 1/5] block: Move bdrv_attach_child() calls up the call chain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, qemu-devel@nongnu.org, stefanha@redhat.com On 08.07.2015 21:36, Kevin Wolf wrote: > Let the callers of bdrv_open_inherit() call bdrv_attach_child(). It > needs to be called in all cases where bdrv_open_inherit() succeeds (i.e. > returns 0) and a child_role is given. > > bdrv_attach_child() is moved upwards to avoid a forward declaration. > > Signed-off-by: Kevin Wolf > --- > block.c | 41 +++++++++++++++++++++-------------------- > 1 file changed, 21 insertions(+), 20 deletions(-) Reviewed-by: Max Reitz