From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDans-0005wd-Sy for qemu-devel@nongnu.org; Fri, 10 Jul 2015 12:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDanr-0006ks-L5 for qemu-devel@nongnu.org; Fri, 10 Jul 2015 12:05:32 -0400 References: <1436384203-10576-1-git-send-email-kwolf@redhat.com> <1436384203-10576-5-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <559FED40.6080208@redhat.com> Date: Fri, 10 Jul 2015 18:05:20 +0200 MIME-Version: 1.0 In-Reply-To: <1436384203-10576-5-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4 4/5] block: Reorder cleanups in bdrv_close() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, qemu-devel@nongnu.org, stefanha@redhat.com On 08.07.2015 21:36, Kevin Wolf wrote: > Block drivers may still want to access their child nodes in their > .bdrv_close handler. If they unref and/or detach a child by themselves, > this should not result in a double free. > > There is additional code for backing files, which are just a special > case of child nodes. The same applies for them. > > Signed-off-by: Kevin Wolf > --- > block.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz