From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target/sh4: optimize cross-page and indirect jumps
Date: Thu, 8 Jun 2017 22:39:25 -0700 [thread overview]
Message-ID: <559b8c2d-2ff3-81cf-2c99-e8862cb80a40@twiddle.net> (raw)
In-Reply-To: <20170607212058.6124-1-aurelien@aurel32.net>
On 06/07/2017 02:20 PM, Aurelien Jarno wrote:
> if (ctx->singlestep_enabled)
> gen_helper_debug(cpu_env);
> - tcg_gen_exit_tb(0);
> + tcg_gen_lookup_and_goto_ptr(cpu_pc);
That really should be an else for that if, since helper_debug doesn't return.
r~
prev parent reply other threads:[~2017-06-09 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 21:20 [Qemu-devel] [PATCH] target/sh4: optimize cross-page and indirect jumps Aurelien Jarno
2017-06-09 5:39 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559b8c2d-2ff3-81cf-2c99-e8862cb80a40@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).