* [Qemu-devel] [PATCH for-2.4] tci: Fix regression with INDEX_op_qemu_st_i32, INDEX_op_qemu_st_i64
@ 2015-07-10 19:22 Stefan Weil
2015-07-11 7:51 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2015-07-10 19:22 UTC (permalink / raw)
To: QEMU Developer, Peter Maydell, Richard Henderson; +Cc: Stefan Weil
Commit 59227d5d45bb3c31dc2118011691c35b3c00879c did not update the
code in tcg/tci/tcg-target.c for those two cases.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
Peter, could you please apply this patch directly (after Richard's review)?
Maybe this is simpler than waiting for a pull request.
Regards
Stefan
tcg/tci/tcg-target.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c
index fb2339d..c6133d2 100644
--- a/tcg/tci/tcg-target.c
+++ b/tcg/tci/tcg-target.c
@@ -788,9 +788,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args,
tcg_out_r(s, *args++);
}
tcg_out_i(s, *args++);
-#ifdef CONFIG_SOFTMMU
- tcg_out_i(s, *args);
-#endif
break;
case INDEX_op_qemu_st_i64:
tcg_out_r(s, *args++);
@@ -802,9 +799,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args,
tcg_out_r(s, *args++);
}
tcg_out_i(s, *args++);
-#ifdef CONFIG_SOFTMMU
- tcg_out_i(s, *args);
-#endif
break;
case INDEX_op_mov_i32: /* Always emitted via tcg_out_mov. */
case INDEX_op_mov_i64:
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.4] tci: Fix regression with INDEX_op_qemu_st_i32, INDEX_op_qemu_st_i64
2015-07-10 19:22 [Qemu-devel] [PATCH for-2.4] tci: Fix regression with INDEX_op_qemu_st_i32, INDEX_op_qemu_st_i64 Stefan Weil
@ 2015-07-11 7:51 ` Richard Henderson
2015-07-13 10:35 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2015-07-11 7:51 UTC (permalink / raw)
To: Stefan Weil, QEMU Developer, Peter Maydell
On 07/10/2015 08:22 PM, Stefan Weil wrote:
> Commit 59227d5d45bb3c31dc2118011691c35b3c00879c did not update the
> code in tcg/tci/tcg-target.c for those two cases.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Peter, could you please apply this patch directly (after Richard's review)?
> Maybe this is simpler than waiting for a pull request.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.4] tci: Fix regression with INDEX_op_qemu_st_i32, INDEX_op_qemu_st_i64
2015-07-11 7:51 ` Richard Henderson
@ 2015-07-13 10:35 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2015-07-13 10:35 UTC (permalink / raw)
To: Richard Henderson; +Cc: Stefan Weil, QEMU Developer
On 11 July 2015 at 08:51, Richard Henderson <rth@twiddle.net> wrote:
> On 07/10/2015 08:22 PM, Stefan Weil wrote:
>>
>> Commit 59227d5d45bb3c31dc2118011691c35b3c00879c did not update the
>> code in tcg/tci/tcg-target.c for those two cases.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>
>> Peter, could you please apply this patch directly (after Richard's
>> review)?
>> Maybe this is simpler than waiting for a pull request.
>
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-13 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-10 19:22 [Qemu-devel] [PATCH for-2.4] tci: Fix regression with INDEX_op_qemu_st_i32, INDEX_op_qemu_st_i64 Stefan Weil
2015-07-11 7:51 ` Richard Henderson
2015-07-13 10:35 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).