From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Richard Henderson <rth@twiddle.net>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Semantics of tcg_enabled() and what it means for multi-arch
Date: Sun, 12 Jul 2015 00:23:23 +0200 [thread overview]
Message-ID: <55A1975B.5000500@redhat.com> (raw)
In-Reply-To: <CAEgOgz7FbShvfsz3E_QPmj-Xv8tWbkmimWO+65xrQoQH7wp7sA@mail.gmail.com>
On 11/07/2015 22:46, Peter Crosthwaite wrote:
> include/exec/ram_addr.h: if (tcg_enabled()) {
> include/exec/ram_addr.h: uint8_t clients = tcg_enabled() ?
> DIRTY_CLIENTS_ALL : DIRTY_CLIENTS_NOCODE;
> memory.c: mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c: mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c: mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c: mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
>
> So what is the correct logic for populating dirty_log_mask and friends
> when there are 0. 1, or more TCG engines?
I think it should be set if there's at least one TCG engine.
Have you checked BTW it the DIRTY_MEMORY_CODE stuff works with multiple
tcg_ctxs _and_ the same page hosts code for more than one CPU type?
Offhand I have no idea of the answer...
Paolo
next prev parent reply other threads:[~2015-07-11 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 20:46 [Qemu-devel] Semantics of tcg_enabled() and what it means for multi-arch Peter Crosthwaite
2015-07-11 22:23 ` Paolo Bonzini [this message]
2015-07-11 22:45 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A1975B.5000500@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).