From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53247)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZECrY-00028A-Pb
	for qemu-devel@nongnu.org; Sun, 12 Jul 2015 04:43:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZECrV-0008K6-K9
	for qemu-devel@nongnu.org; Sun, 12 Jul 2015 04:43:52 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:52041)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZECrV-0008Jv-Ap
	for qemu-devel@nongnu.org; Sun, 12 Jul 2015 04:43:49 -0400
References: <cover.1436665556.git.crosthwaite.peter@gmail.com>
	<5acb4fd7a4bc6a2d3f1abe4eb456403af1704765.1436665556.git.crosthwaite.peter@gmail.com>
From: Laurent Vivier <laurent@vivier.eu>
Message-ID: <55A228BC.5080106@vivier.eu>
Date: Sun, 12 Jul 2015 10:43:40 +0200
MIME-Version: 1.0
In-Reply-To: <5acb4fd7a4bc6a2d3f1abe4eb456403af1704765.1436665556.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific
	disas setup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>, afaerber@suse.de, Greg Ungerer <gerg@uclinux.org>



Le 12/07/2015 04:00, Peter Crosthwaite a écrit :
> From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
> 
> Move the target_disas() m68k specifics to the QOM disas_set_info hook
> and delete the #ifdef specific code in disas.c.
> 
> Cc: Greg Ungerer <gerg@uclinux.org>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> Testing:
> I cant find binaries for this arch easily, but I got this from executing
> random code:
> 
> $ ./m68k-softmmu/qemu-system-m68k -kernel ./random_code -S -nographic -d in_asm 2> err
> QEMU 2.3.90 monitor - type 'help' for more information
> (qemu) xp 0x40000000
> 0000000040000000: 0x7d413a22
> (qemu) xp/i 0x40000000
> 0x40000000:  mvsw %d1,%d6
> (qemu) xp/i 0x40000004
> 0x40000004:  addqb #2,%a0@(27614)
> (qemu) c
> (qemu) Aborted (core dumped)
> 
> $ more err
> qemu: fatal: Illegal instruction: 7d41 @ 40000000
> ---
>  disas.c           | 4 ----
>  target-m68k/cpu.c | 7 +++++++
>  2 files changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Laurent Vivier <laurent@vivier.eu>