From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEZ7W-0002tv-Fz for qemu-devel@nongnu.org; Mon, 13 Jul 2015 04:29:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEZ7S-000712-BB for qemu-devel@nongnu.org; Mon, 13 Jul 2015 04:29:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEZ7S-00070x-4V for qemu-devel@nongnu.org; Mon, 13 Jul 2015 04:29:46 -0400 Message-ID: <55A376F5.6020300@redhat.com> Date: Mon, 13 Jul 2015 16:29:41 +0800 From: Jason Wang MIME-Version: 1.0 References: <1436766411-29144-1-git-send-email-jasowang@redhat.com> <1436766411-29144-4-git-send-email-jasowang@redhat.com> <20150713081617.2898650f.cornelia.huck@de.ibm.com> In-Reply-To: <20150713081617.2898650f.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, mst@redhat.com On 07/13/2015 02:16 PM, Cornelia Huck wrote: > On Mon, 13 Jul 2015 13:46:50 +0800 > Jason Wang wrote: > >> This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. >> >> This is because: >> - vhost support virtio 1.0 now >> - transport code (e.g virtio-pci) set this feature when modern is >> enabled, setting this unconditionally will break disable-modern=on. > *scratches head* > > Why is transport code now supposed to set VERSION_1? I thought we > wanted to have the individual devices offer it, once they are converted. As Michael pointed out, all device have been converted. And offering this in device needs knowledge of transport capability but device should know nothing about this. > > No objection on removing the dependency on !vhost. > >> Cc: Cornelia Huck >> Signed-off-by: Jason Wang >> --- >> hw/net/virtio-net.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c >> index d728233..e3c2db3 100644 >> --- a/hw/net/virtio-net.c >> +++ b/hw/net/virtio-net.c >> @@ -466,7 +466,6 @@ static uint64_t virtio_net_get_features(VirtIODevice *vdev, uint64_t features) >> } >> >> if (!get_vhost_net(nc->peer)) { >> - virtio_add_feature(&features, VIRTIO_F_VERSION_1); >> return features; >> } >> return vhost_net_get_features(get_vhost_net(nc->peer), features);