From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEali-0008HD-7E for qemu-devel@nongnu.org; Mon, 13 Jul 2015 06:15:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEale-0003d0-0i for qemu-devel@nongnu.org; Mon, 13 Jul 2015 06:15:26 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:35627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEald-0003bv-PJ for qemu-devel@nongnu.org; Mon, 13 Jul 2015 06:15:21 -0400 Received: by wgjx7 with SMTP id x7so291943257wgj.2 for ; Mon, 13 Jul 2015 03:15:21 -0700 (PDT) Sender: Paolo Bonzini References: <1433517363-32335-1-git-send-email-pbonzini@redhat.com> <1433517363-32335-13-git-send-email-pbonzini@redhat.com> <55A2752E.9010903@redhat.com> <55A35F21.2040606@redhat.com> From: Paolo Bonzini Message-ID: <55A38FB6.2040301@redhat.com> Date: Mon, 13 Jul 2015 12:15:18 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 13/07/2015 10:55, Peter Maydell wrote: > Yes, that would make sense. But why do we need to do more > full invalidates now? Because the board doesn't call memory_region_set_log. > > You can just add a memory_region_set_log call for the integratorcp and > > versatilepb RAM regions. > > It seems a bit of a shame that we basically broke previously > working configs for all our boards with embedded framebuffer > in RAM :-( They are not broken, just less efficient. But it's easy to fix; I'll prepare the patch to add memory_region_set_log. Paolo