From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEaop-00049s-BD for qemu-devel@nongnu.org; Mon, 13 Jul 2015 06:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEaol-0004ak-Bb for qemu-devel@nongnu.org; Mon, 13 Jul 2015 06:18:39 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:37754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEaol-0004ae-3O for qemu-devel@nongnu.org; Mon, 13 Jul 2015 06:18:35 -0400 Received: by wicmz13 with SMTP id mz13so57458626wic.0 for ; Mon, 13 Jul 2015 03:18:34 -0700 (PDT) Sender: Paolo Bonzini References: <1436439674-51226-1-git-send-email-cornelia.huck@de.ibm.com> <20150713110144.6b6befae.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <55A39077.1060208@redhat.com> Date: Mon, 13 Jul 2015 12:18:31 +0200 MIME-Version: 1.0 In-Reply-To: <20150713110144.6b6befae.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , qemu-devel@nongnu.org Cc: kraxel@redhat.com, mst@redhat.com On 13/07/2015 11:01, Cornelia Huck wrote: > On Thu, 9 Jul 2015 13:01:14 +0200 > Cornelia Huck wrote: > >> 64 bit props used 32 bit callbacks in two places, leading to broken >> feature bits on virtio (example: got 0x31000000000006d4 which is >> obviously bogus). Fix this. >> >> Fixes: fdba6d96 ("qdev: add 64bit properties") >> Signed-off-by: Cornelia Huck >> --- >> hw/core/qdev-properties.c | 2 +- >> include/hw/qdev-properties.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > Ping? I think this should go into 2.4-rc1. I'll queue it. Paolo