From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZEcfa-0007L8-VM
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 08:17:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZEcfX-0003bR-84
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 08:17:14 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1436772617-2490-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA9gbPB8PTimK7J=wAC8gtQtgFxLhEkGOESD1r52f9-m6w@mail.gmail.com>
	<1436788098.26533.22.camel@redhat.com>
	<1436788900.26533.25.camel@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55A3AC44.9070705@redhat.com>
Date: Mon, 13 Jul 2015 14:17:08 +0200
MIME-Version: 1.0
In-Reply-To: <1436788900.26533.25.camel@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-input: enable on non-linux hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>



On 13/07/2015 14:01, Gerd Hoffmann wrote:
>> > 
>> > Did a build test on freebsd -- passed.
> Oops, the windows cross builds fails though (due to
> include/standard-headers/linux/input.h including sys/ioctl.h).
> 
> Ok, scratch that one, back to the drawing board ...

The sys/ioctl.h include doesn't seem too useful.  This patch compiles:

diff --git a/hw/input/virtio-input-host.c b/hw/input/virtio-input-host.c
index f7e3d84..3feecfd 100644
--- a/hw/input/virtio-input-host.c
+++ b/hw/input/virtio-input-host.c
@@ -12,6 +12,7 @@
 #include "hw/virtio/virtio-input.h"

 #include "standard-headers/linux/input.h"
+#include <sys/ioctl.h>

 /* ----------------------------------------------------------------- */

diff --git a/include/standard-headers/linux/input.h
b/include/standard-headers/linux/input.h
index a459dd2..b003c67 100644
--- a/include/standard-headers/linux/input.h
+++ b/include/standard-headers/linux/input.h
@@ -10,7 +10,6 @@


 #include <sys/time.h>
-#include <sys/ioctl.h>
 #include <sys/types.h>
 #include "standard-headers/linux/types.h"


Perhaps we can drop the include in scripts/update-linux-headers.sh?

Paolo