From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEeaf-0006Ap-5W for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:20:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEeaa-0000ZW-Va for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:20:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38512 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEeaa-0000YT-PC for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:20:12 -0400 Message-ID: <55A3C919.1040400@suse.de> Date: Mon, 13 Jul 2015 16:20:09 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1436460692-5142-1-git-send-email-cornelia.huck@de.ibm.com> <1436460692-5142-2-git-send-email-cornelia.huck@de.ibm.com> <55A3AD6D.5010303@de.ibm.com> <20150713161152.3e519fcd.cornelia.huck@de.ibm.com> In-Reply-To: <20150713161152.3e519fcd.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Christian Borntraeger Cc: peter.crosthwaite@xilinx.com, gesaint@linux.vnet.ibm.com, jfrei@linux.vnet.ibm.com, qemu-devel@nongnu.org, agraf@suse.de Am 13.07.2015 um 16:11 schrieb Cornelia Huck: > On Mon, 13 Jul 2015 14:22:05 +0200 > Christian Borntraeger wrote: >=20 >> Am 09.07.2015 um 18:51 schrieb Cornelia Huck: >>> Devices that don't live on a bus aren't caught by the normal device >>> reset logic. Let's register a reset handler for those devices during >>> device realization that calls the reset handler for the associated >>> device class. >>> >>> Suggested-by: Peter Crosthwaite >>> Signed-off-by: Cornelia Huck >> reboot (from within guest) and external reset (system_reset in monitor= ) >> now work fine with the s390 watchdog. >> >> Tested-by: Christian Borntraeger >> >>> --- >>> hw/core/qdev.c | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >=20 > Thanks. >=20 > Any objections against taking this through s390-next? I'd like to fix > diag288 reset (+ that annoying migration regession) for 2.4-rc1 and > send a pull request soon. Which device does this fix (only this diag88?), and is it really not possible to register a reset handler where it's being created? Peter C.'s theory does not match practice for x86, and this patch will lead to bus-less devices that are properly being reset by their parent getting reset twice, potentially causing issues due to qemu_irqs. I'd rather avoid that. One workaround would be to amend this patch with a DeviceClass flag for whether to enable this new behavior, defaulting to no and getting overridden by your affected device. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)