From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] libcacard: cac_is_cac_card?
Date: Mon, 13 Jul 2015 16:31:42 +0200 [thread overview]
Message-ID: <55A3CBCE.4000606@redhat.com> (raw)
In-Reply-To: <55A3B2E2.9060301@msgid.tls.msk.ru>
On 13/07/2015 14:45, Michael Tokarev wrote:
> Ping?
>
> 27.04.2015 09:56, Michael Tokarev wrote:
>> This function is declared in libcacard/cac.h
>>
>> VCardStatus cac_is_cac_card(VReader *reader);
>>
>> it is referenced in a ifdef-ed out code in libcacard/vcard_emul_type.c:
>>
>>
>> VCardEmulType vcard_emul_type_select(VReader *vreader)
>> {
>> #ifdef notdef
>> /* since there is only one emulator no need to call this function */
>> if (cac_is_cac_card(vreader) == VCARD_DONE) {
>> return VCARD_EMUL_CAC;
>> }
>> #endif
>> /* return the default */
>> return VCARD_EMUL_CAC;
>> }
>>
>> and it is mentioned in libcacard/libcacard.syms.
>>
>> But it is not defined anywhere. Should it be removed
>> from all places it is referenced at, or should it be
>> implemented instead?
If it's not defined, its mention in libcacard.syms has no effect and the
references can be removed.
Paolo
next prev parent reply other threads:[~2015-07-13 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 6:56 [Qemu-devel] libcacard: cac_is_cac_card? Michael Tokarev
2015-07-13 12:45 ` Michael Tokarev
2015-07-13 14:31 ` Paolo Bonzini [this message]
2015-07-13 14:38 ` Michael Tokarev
2015-07-13 14:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3CBCE.4000606@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).