From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49548)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZEelr-0003uF-Lp
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:31:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZEeln-00054r-Co
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:31:51 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:35540)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZEeln-00054m-5x
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:31:47 -0400
Received: by wgjx7 with SMTP id x7so297517929wgj.2
	for <qemu-devel@nongnu.org>; Mon, 13 Jul 2015 07:31:46 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <553DDD8D.6050602@msgid.tls.msk.ru>
	<55A3B2E2.9060301@msgid.tls.msk.ru>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55A3CBCE.4000606@redhat.com>
Date: Mon, 13 Jul 2015 16:31:42 +0200
MIME-Version: 1.0
In-Reply-To: <55A3B2E2.9060301@msgid.tls.msk.ru>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] libcacard: cac_is_cac_card?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>



On 13/07/2015 14:45, Michael Tokarev wrote:
> Ping?
> 
> 27.04.2015 09:56, Michael Tokarev wrote:
>> This function is declared in libcacard/cac.h
>>
>>  VCardStatus cac_is_cac_card(VReader *reader);
>>
>> it is referenced in a ifdef-ed out code in libcacard/vcard_emul_type.c:
>>
>>
>> VCardEmulType vcard_emul_type_select(VReader *vreader)
>> {
>> #ifdef notdef
>>     /* since there is only one emulator no need to call this function */
>>     if (cac_is_cac_card(vreader) == VCARD_DONE) {
>>         return VCARD_EMUL_CAC;
>>     }
>> #endif
>>     /* return the default */
>>     return VCARD_EMUL_CAC;
>> }
>>
>> and it is mentioned in libcacard/libcacard.syms.
>>
>> But it is not defined anywhere.  Should it be removed
>> from all places it is referenced at, or should it be
>> implemented instead?

If it's not defined, its mention in libcacard.syms has no effect and the
references can be removed.

Paolo