[Qemu-devel] libcacard: cac_is_cac_card?

[Qemu-devel] libcacard: cac_is_cac_card?

[Michael Tokarev]

This function is declared in libcacard/cac.h

 VCardStatus cac_is_cac_card(VReader *reader);

it is referenced in a ifdef-ed out code in libcacard/vcard_emul_type.c:


VCardEmulType vcard_emul_type_select(VReader *vreader)
{
#ifdef notdef
    /* since there is only one emulator no need to call this function */
    if (cac_is_cac_card(vreader) == VCARD_DONE) {
        return VCARD_EMUL_CAC;
    }
#endif
    /* return the default */
    return VCARD_EMUL_CAC;
}

and it is mentioned in libcacard/libcacard.syms.

But it is not defined anywhere.  Should it be removed
from all places it is referenced at, or should it be
implemented instead?

Thanks,

/mjt

Re: [Qemu-devel] libcacard: cac_is_cac_card?

[Michael Tokarev]

Ping?

27.04.2015 09:56, Michael Tokarev wrote:
> This function is declared in libcacard/cac.h
> 
>  VCardStatus cac_is_cac_card(VReader *reader);
> 
> it is referenced in a ifdef-ed out code in libcacard/vcard_emul_type.c:
> 
> 
> VCardEmulType vcard_emul_type_select(VReader *vreader)
> {
> #ifdef notdef
>     /* since there is only one emulator no need to call this function */
>     if (cac_is_cac_card(vreader) == VCARD_DONE) {
>         return VCARD_EMUL_CAC;
>     }
> #endif
>     /* return the default */
>     return VCARD_EMUL_CAC;
> }
> 
> and it is mentioned in libcacard/libcacard.syms.
> 
> But it is not defined anywhere.  Should it be removed
> from all places it is referenced at, or should it be
> implemented instead?
> 
> Thanks,
> 
> /mjt
> 

Re: [Qemu-devel] libcacard: cac_is_cac_card?

[Paolo Bonzini]

On 13/07/2015 14:45, Michael Tokarev wrote:
> Ping?
> 
> 27.04.2015 09:56, Michael Tokarev wrote:
>> This function is declared in libcacard/cac.h
>>
>>  VCardStatus cac_is_cac_card(VReader *reader);
>>
>> it is referenced in a ifdef-ed out code in libcacard/vcard_emul_type.c:
>>
>>
>> VCardEmulType vcard_emul_type_select(VReader *vreader)
>> {
>> #ifdef notdef
>>     /* since there is only one emulator no need to call this function */
>>     if (cac_is_cac_card(vreader) == VCARD_DONE) {
>>         return VCARD_EMUL_CAC;
>>     }
>> #endif
>>     /* return the default */
>>     return VCARD_EMUL_CAC;
>> }
>>
>> and it is mentioned in libcacard/libcacard.syms.
>>
>> But it is not defined anywhere.  Should it be removed
>> from all places it is referenced at, or should it be
>> implemented instead?

If it's not defined, its mention in libcacard.syms has no effect and the
references can be removed.

Paolo

Re: [Qemu-devel] libcacard: cac_is_cac_card?

[Michael Tokarev]

13.07.2015 17:31, Paolo Bonzini wrote:
>>> and it is mentioned in libcacard/libcacard.syms.
>>>
>>> But it is not defined anywhere.

> If it's not defined, its mention in libcacard.syms has no effect and the
> references can be removed.

That's two statements.  First statement - its mention in .syms has no
effect - is a bit wrong.  I found it _because_ this mention has some
effect.  In particular, when building it on Debian the package system
complains that it can't find the symbol to be exported.

But okay, I'll just remove it from the .syms file.

Thanks,

/mjt

Re: [Qemu-devel] libcacard: cac_is_cac_card?

[Paolo Bonzini]

On 13/07/2015 16:38, Michael Tokarev wrote:
>> > If it's not defined, its mention in libcacard.syms has no effect and the
>> > references can be removed.
> That's two statements.  First statement - its mention in .syms has no
> effect - is a bit wrong.  I found it _because_ this mention has some
> effect.  In particular, when building it on Debian the package system
> complains that it can't find the symbol to be exported.

Oh, interesting.  It has no effect *on the ABI*, though, right?

Paolo

> But okay, I'll just remove it from the .syms file.